[Bug network/16529] New: netinet/in.h breaks -pedantic

[Bug network/16529] New: netinet/in.h breaks -pedantic

[alvarezp at alvarezp dot ods.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16529

            Bug ID: 16529
           Summary: netinet/in.h breaks -pedantic
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: network
          Assignee: unassigned at sourceware dot org
          Reporter: alvarezp at alvarezp dot ods.org

Created attachment 7393
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7393&action=edit
Fix: comma at end of enum broke -pedantic

netinet/in.h breaks -pedantic

$ gcc -Wall -Wextra -Werror -pedantic -pedantic-errors -D_POSIX_C_SOURCE -o in
in-standard.c
In file included from in-standard.c:1:0:
/home/user/src/glibc/inet/netinet/in.h:111:21: error: comma at end of
enumerator list [-pedantic]

Line 111 was introduced by commit 6c82a2f8 [1] so there's not much history
about it. Simply the comma needs to be removed.

[1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=6c82a2f8

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/16529] netinet/in.h breaks -pedantic

[bugdal at aerifal dot cx]

https://sourceware.org/bugzilla/show_bug.cgi?id=16529

Rich Felker <bugdal at aerifal dot cx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugdal at aerifal dot cx

--- Comment #1 from Rich Felker <bugdal at aerifal dot cx> ---
Isn't GCC supposed to ignore such issues in system headers? I don't think glibc
has an obligation to satisfy the GCC developers' style guidelines, unless this
is actually an issue of the current code being invalid C.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/16529] netinet/in.h breaks -pedantic

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=16529

--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
Headers are generally meant to be (C90 + long long) if possible, without 
requiring other C99 features such as trailing commas in enums.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/16529] netinet/in.h breaks -pedantic

[alvarezp at alvarezp dot ods.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16529

--- Comment #3 from Octavio Alvarez <alvarezp at alvarezp dot ods.org> ---
It is invalid C before C99.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/16529] netinet/in.h breaks -pedantic

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16529

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Carlos O'Donell <carlos at redhat dot com> ---
Fixed for master and thus fixed for 2.19.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/16529] netinet/in.h breaks -pedantic

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16529

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.