public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bugdal at aerifal dot cx" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug dynamic-link/16585] dlsym() shouldn't be declared as leaf
Date: Fri, 14 Feb 2014 18:26:00 -0000	[thread overview]
Message-ID: <bug-16585-131-v55zLHD2FV@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16585-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=16585

Rich Felker <bugdal at aerifal dot cx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugdal at aerifal dot cx

--- Comment #7 from Rich Felker <bugdal at aerifal dot cx> ---
It seems like a bug to me that dlsym is calling malloc. Whatever resources it
might need should already have been allocated as part of dlopen. The IFUNC
issue potentially remains, but really there should be formal restrictions on
what functions IFUNC resolvers are allowed to call; without that, I don't think
any code can be safe in the presence of IFUNCs unless the dynamic linker
resolves them all at load time rather than lazily (BTW, this would probably be
a good idea.)

As for working around the issue reported here, an alternate approach is calling
dlsym via a volatile function pointer with non-leaf type. This will ensure that
the compiler cannot optimize based on the leaf property.

Still, I agree dlsym is not a hot path, so the leaf property should probably
just be removed. See issue #14989 for details on why dlsym is _required_ to be
slow and how glibc is non-conforming in this regard.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2014-02-14 18:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14 14:40 [Bug dynamic-link/16585] New: " stefan at codesourcery dot com
2014-02-14 15:38 ` [Bug dynamic-link/16585] " amonakov at gmail dot com
2014-02-14 15:51 ` carlos at redhat dot com
2014-02-14 16:07 ` stefan at codesourcery dot com
2014-02-14 16:27 ` amonakov at gmail dot com
2014-02-14 16:34 ` jakub at redhat dot com
2014-02-14 16:37 ` jakub at redhat dot com
2014-02-14 16:54 ` amonakov at gmail dot com
2014-02-14 18:26 ` bugdal at aerifal dot cx [this message]
2014-02-14 22:09 ` carlos at redhat dot com
2014-02-15  8:32 ` amonakov at gmail dot com
2014-02-21 18:25 ` carlos at redhat dot com
2014-06-13  8:15 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16585-131-v55zLHD2FV@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).