[Bug nscd/16639] New: systemctl start nscd.service should return non-zero status on failure

[Bug nscd/16639] New: systemctl start nscd.service should return non-zero status on failure

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

            Bug ID: 16639
           Summary: systemctl start nscd.service should return non-zero
                    status on failure
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nscd
          Assignee: unassigned at sourceware dot org
          Reporter: siddhesh at redhat dot com
                CC: drepper.fsp at gmail dot com

Currently the nscd service is installed in systemd as a simple service, which
means that it is able to handle its own errors and does not quit.  Since nscd
does not fit that description, i.e. it can exit on errors like, say, failing to
parse nscd.conf, it should be declared as forking instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nscd/16639] systemctl start nscd.service should return non-zero status on failure

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |siddhesh at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nscd/16639] systemctl start nscd.service should return non-zero status on failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  532a60357ef4c5852cc1bf836cfd9d6f093ef204 (commit)
      from  d6285c9f0b3972369356554727b1ede5a6eb0731 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=532a60357ef4c5852cc1bf836cfd9d6f093ef204

commit 532a60357ef4c5852cc1bf836cfd9d6f093ef204
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Mon Mar 3 22:51:39 2014 +0530

    nscd: Improved support for tracking startup failure in nscd service (BZ
#16639)

    Currently, the nscd parent process parses commandline options and
    configuration, forks on startup and immediately exits with a success.
    If the child process encounters some error after this, it goes
    undetected and any services started up after it may have to repeatedly
    check to make sure that the nscd service did actually start up and is
    serving requests.

    To make this process more reliable, I have added a pipe between the
    parent and child process, through which the child process sends a
    notification to the parent informing it of its status.  The parent
    waits for this status and once it receives it, exits with the
    corresponding exit code.  So if the child service sends a success
    status (0), the parent exits with a success status.  Similarly for
    error conditions, the child sends the non-zero status code, which the
    parent passes on as the exit code.

    This, along with setting the nscd service type to forking in its
    systemd configuration file, allows systemd to be certain that the nscd
    service is ready and is accepting connections.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog          |   22 +++++++++++
 nscd/connections.c |   48 ++++++++++++-----------
 nscd/nscd.c        |  108 +++++++++++++++++++++++++++++++++++++++++++++++++--
 nscd/nscd.h        |    2 +
 nscd/selinux.c     |   18 ++++----
 5 files changed, 161 insertions(+), 37 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nscd/16639] systemctl start nscd.service should return non-zero status on failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8b4ff97413fc32ea7f817586bc682ff2cc34527b (commit)
      from  54b46a4b3efd179ccbbf8e342e64391e2b590f1b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8b4ff97413fc32ea7f817586bc682ff2cc34527b

commit 8b4ff97413fc32ea7f817586bc682ff2cc34527b
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Mon Mar 10 13:17:54 2014 +0530

    Mark nscd service as forking in systemd service file (BZ #16639)

    Currently the nscd service is installed in systemd as a simple
    service, which means that it is able to handle its own errors and does
    not quit.  Since nscd does not fit that description, i.e. it can exit
    on errors like, say, failing to parse nscd.conf, it should be declared
    as forking instead.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog         |    5 +++++
 NEWS              |    2 +-
 nscd/nscd.service |    4 ++--
 3 files changed, 8 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nscd/16639] systemctl start nscd.service should return non-zero status on failure

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Siddhesh Poyarekar <siddhesh at redhat dot com> ---
Fixed in master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nscd/16639] systemctl start nscd.service should return non-zero status on failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16639

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.