[Bug math/16918] New: [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[Bug math/16918] New: [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

            Bug ID: 16918
           Summary: [arm] feupdateenv (FE_NOMASK_ENV) should check for
                    failure
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
              Host: arm*-*-*

Similar to bug 14866 and bug 14907, the ARM implementation of feupdateenv needs
to check for failure to enable exception traps when called with FE_NOMASK_ENV
as argument.  At present, it ignores the return value from fesetenv.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  db59bad394ef61bf6d6ef7916012f2a09d0b3d11 (commit)
      from  001f7b773c637560ecfa686452a5e68d60d07db3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=db59bad394ef61bf6d6ef7916012f2a09d0b3d11

commit db59bad394ef61bf6d6ef7916012f2a09d0b3d11
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 13:53:04 2014 +0000

    Rewrite feupdateenv

    This patch rewrites feupdateenv to improve performance by avoiding
    unnecessary FPSCR reads/writes. It fixes bug 16918 by passing the
    correct return value.

    2014-06-24  Wilco  <wdijkstr@arm.com>

        [BZ #16918]
        * sysdeps/arm/feupdateenv.c (feupdateenv):
        Rewrite to reduce FPSCR accesses and fix return value.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                 |    6 ++++++
 sysdeps/arm/feupdateenv.c |   44 ++++++++++++++++++++++++++++++++++++++------
 2 files changed, 44 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  b8c005732e1f799ffcd522d83aa2a826b6248752 (commit)
       via  b5570d92d6bb6ba9c25ac6ed77ba170dd7f4acd3 (commit)
       via  947bdca24d1ada7e83cf266213dba02c99d035a5 (commit)
       via  00f669edb8c447cbe4e73d8067abd3146c5c312b (commit)
       via  222b787a6fd36601f5c5d22378176798327fcf31 (commit)
      from  db59bad394ef61bf6d6ef7916012f2a09d0b3d11 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b8c005732e1f799ffcd522d83aa2a826b6248752

commit b8c005732e1f799ffcd522d83aa2a826b6248752
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 15:05:23 2014 +0000

    Optimize fesetenv

    Improve fesetenv to use an optimized implementation similar to
    feupdateenv.

    2014-06-24  Wilco  <wdijkstr@arm.com>

        * sysdeps/arm/fesetenv.c (fesetenv): Optimize implementation.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b5570d92d6bb6ba9c25ac6ed77ba170dd7f4acd3

commit b5570d92d6bb6ba9c25ac6ed77ba170dd7f4acd3
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 15:02:51 2014 +0000

    Add _FPU_MASK_RM and use it instead of FE_TOWARDZERO.

    2014-06-24  Wilco  <wdijkstr@arm.com>

        * sysdeps/arm/fpu_control.h (_FPU_MASK_RM): Define.
        * sysdeps/arm/fenv_private.h (libc_fesetround_vfp)
        (libc_feholdexcept_setround_vfp) (libc_feholdsetround_vfp)
        (libc_feresetround_vfp) (libc_feholdsetround_vfp_ctx)
        (libc_feresetround_vfp_ctx): Use _FPU_MASK_RM.
        * sysdeps/arm/fesetround.c (fesetround): Use _FPU_MASK_RM.
        * sysdeps/arm/get-rounding-mode.h (get_rounding_mode):
        Use _FPU_MASK_RM.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=947bdca24d1ada7e83cf266213dba02c99d035a5

commit 947bdca24d1ada7e83cf266213dba02c99d035a5
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 15:00:01 2014 +0000

    Remove an unused include.

    2014-06-24  Wilco  <wdijkstr@arm.com>

        * sysdeps/arm/fsetexcptflg.c (fesetexceptflag): Remove unused include.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=00f669edb8c447cbe4e73d8067abd3146c5c312b

commit 00f669edb8c447cbe4e73d8067abd3146c5c312b
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 14:57:32 2014 +0000

    Cleanup fenv implementation

    Remove some spaces before libm_hidden_def.

    2014-06-24  Wilco  <wdijkstr@arm.com>

        * sysdeps/arm/feholdexcpt.c (feholdexcept): Remove space.
        * sysdeps/arm/fesetenv.c (fesetenv): Remove space.
        * sysdeps/arm/fesetround.c (fesetround): Remove space.
        * sysdeps/arm/fraiseexcpt.c (feraiseexcept): Remove space.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=222b787a6fd36601f5c5d22378176798327fcf31

commit 222b787a6fd36601f5c5d22378176798327fcf31
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 14:48:05 2014 +0000

    Add bug 16918 to NEWS.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                       |   30 ++++++++++++++++++++++++++++++
 NEWS                            |   11 ++++++++---
 sysdeps/arm/feholdexcpt.c       |    1 -
 sysdeps/arm/fenv_private.h      |   16 ++++++++--------
 sysdeps/arm/fesetenv.c          |   36 ++++++++++++++++++++----------------
 sysdeps/arm/fesetround.c        |    4 +---
 sysdeps/arm/fpu_control.h       |    4 ++--
 sysdeps/arm/fraiseexcpt.c       |    1 -
 sysdeps/arm/fsetexcptflg.c      |    1 -
 sysdeps/arm/get-rounding-mode.h |    2 +-
 10 files changed, 70 insertions(+), 36 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  56046ce63717cc16e0cabe135e721b82596955fe (commit)
      from  b8c005732e1f799ffcd522d83aa2a826b6248752 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=56046ce63717cc16e0cabe135e721b82596955fe

commit 56046ce63717cc16e0cabe135e721b82596955fe
Author: Marcus Shawcroft <marcus.shawcroft@arm.com>
Date:   Tue Jun 24 16:28:06 2014 +0100

    Revert "Add bug 16918 to NEWS."

    This reverts commit 222b787a6fd36601f5c5d22378176798327fcf31.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    4 ----
 NEWS      |   11 +++--------
 2 files changed, 3 insertions(+), 12 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c0a4ed7799372c606c5b9aa0d4d84e3867fd09a5 (commit)
      from  56046ce63717cc16e0cabe135e721b82596955fe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c0a4ed7799372c606c5b9aa0d4d84e3867fd09a5

commit c0a4ed7799372c606c5b9aa0d4d84e3867fd09a5
Author: Wilco <wdijkstr@arm.com>
Date:   Tue Jun 24 15:40:29 2014 +0000

    Add bug 16918 to NEWS.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    4 ++++
 NEWS      |    7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16918] [arm] feupdateenv (FE_NOMASK_ENV) should check for failure

[wdijkstr at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16918

Wilco <wdijkstr at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |wdijkstr at arm dot com
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.20

--- Comment #5 from Wilco <wdijkstr at arm dot com> ---
Fixed for 2.20 by commit db59bad394ef61bf6d6ef7916012f2a09d0b3d11.

-- 
You are receiving this mail because:
You are on the CC list for the bug.