public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/16922] New: MIPS *_SUB instruction macros in sys/asm.h are incorrect
@ 2014-05-07 20:07 sje at gcc dot gnu.org
2014-05-07 20:16 ` [Bug libc/16922] " sje at gcc dot gnu.org
2014-06-12 19:22 ` fweimer at redhat dot com
0 siblings, 2 replies; 3+ messages in thread
From: sje at gcc dot gnu.org @ 2014-05-07 20:07 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16922
Bug ID: 16922
Summary: MIPS *_SUB instruction macros in sys/asm.h are
incorrect
Product: glibc
Version: 2.21
Status: NEW
Severity: minor
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: sje at gcc dot gnu.org
CC: drepper.fsp at gmail dot com
Some of the *_SUB instruction macros in sysdeps/mips/sys/asm.h are defined to
do addition instructions instead of subtraction instructions. I don't know why
this is but it seems obviously wrong and it is different then the definitions
in the linux kernel which do define these as subtract instructions
(arch/mips/include/asm/asm.h).
% grep SUB asm.h | grep add
# define INT_SUB add
# define INT_SUB dadd
# define LONG_SUB add
# define LONG_SUB dadd
# define PTR_SUB add
# define PTR_SUB add
# define PTR_SUB dadd
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug libc/16922] MIPS *_SUB instruction macros in sys/asm.h are incorrect
2014-05-07 20:07 [Bug libc/16922] New: MIPS *_SUB instruction macros in sys/asm.h are incorrect sje at gcc dot gnu.org
@ 2014-05-07 20:16 ` sje at gcc dot gnu.org
2014-06-12 19:22 ` fweimer at redhat dot com
1 sibling, 0 replies; 3+ messages in thread
From: sje at gcc dot gnu.org @ 2014-05-07 20:16 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16922
sje at gcc dot gnu.org <sje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from sje at gcc dot gnu.org <sje at gcc dot gnu.org> ---
Fixed with this checkin:
commit 5057ad3b503eb471b3113090ded9d1ad61759d62
Author: Steve Ellcey <sellcey@mips.com>
Date: Wed May 7 13:10:48 2014 -0700
2014-05-07 Steve Ellcey <sellcey@mips.com>
[BZ# 16922]
* sysdeps/mips/sys/asm.h (INT_SUB): Fix definition.
(LONG_SUB): Ditto.
(PTR_SUB): Ditto.
I also added this bug to the list of fixed bugs in the NEWS file.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug libc/16922] MIPS *_SUB instruction macros in sys/asm.h are incorrect
2014-05-07 20:07 [Bug libc/16922] New: MIPS *_SUB instruction macros in sys/asm.h are incorrect sje at gcc dot gnu.org
2014-05-07 20:16 ` [Bug libc/16922] " sje at gcc dot gnu.org
@ 2014-06-12 19:22 ` fweimer at redhat dot com
1 sibling, 0 replies; 3+ messages in thread
From: fweimer at redhat dot com @ 2014-06-12 19:22 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16922
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |security-
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-12 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-07 20:07 [Bug libc/16922] New: MIPS *_SUB instruction macros in sys/asm.h are incorrect sje at gcc dot gnu.org
2014-05-07 20:16 ` [Bug libc/16922] " sje at gcc dot gnu.org
2014-06-12 19:22 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).