public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug math/16977] New: log10 (1) incorrect in round-downward mode
@ 2014-05-22 22:42 jsm28 at gcc dot gnu.org
2014-05-22 22:43 ` [Bug math/16977] " jsm28 at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2014-05-22 22:42 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16977
Bug ID: 16977
Summary: log10 (1) incorrect in round-downward mode
Product: glibc
Version: 2.19
Status: NEW
Severity: normal
Priority: P2
Component: math
Assignee: unassigned at sourceware dot org
Reporter: jsm28 at gcc dot gnu.org
As per ISO C Annex F, log10 (1) should be +0 in all rounding modes. However,
it returns -1 in round-downward mode for x86_64 for long double, for x86 for
all types, and maybe in other cases.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug math/16977] log10 (1) incorrect in round-downward mode
2014-05-22 22:42 [Bug math/16977] New: log10 (1) incorrect in round-downward mode jsm28 at gcc dot gnu.org
@ 2014-05-22 22:43 ` jsm28 at gcc dot gnu.org
2014-05-23 12:08 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2014-05-22 22:43 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16977
--- Comment #1 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
(Returns -0, not -1, that is.)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug math/16977] log10 (1) incorrect in round-downward mode
2014-05-22 22:42 [Bug math/16977] New: log10 (1) incorrect in round-downward mode jsm28 at gcc dot gnu.org
2014-05-22 22:43 ` [Bug math/16977] " jsm28 at gcc dot gnu.org
@ 2014-05-23 12:08 ` cvs-commit at gcc dot gnu.org
2014-05-23 12:09 ` jsm28 at gcc dot gnu.org
2014-06-12 19:17 ` fweimer at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2014-05-23 12:08 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16977
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via b72592e75fdecb34e2ac5f931730409a1fb68e8a (commit)
from 2302d679ce8b36854022207b58e554b3e89dd8c7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b72592e75fdecb34e2ac5f931730409a1fb68e8a
commit b72592e75fdecb34e2ac5f931730409a1fb68e8a
Author: Joseph Myers <joseph@codesourcery.com>
Date: Fri May 23 12:07:50 2014 +0000
Fix log10 (1) in round-downward mode (bug 16977).
As with various other issues of this kind, bug 16977 is log10 (1)
wrongly returning -0 rather than +0 in round-downward mode because of
an implementation effectively in terms of log1p (x - 1). This patch
fixes the issue in the same way used for log.
Tested x86_64 and x86 and ulps updated accordingly. Also tested for
mips64 to confirm a fix was needed for ldbl-128 and to validate that
fix (also applied to ldbl-128ibm since that version of logl is
essentially the same as the ldbl-128 one).
[BZ #16977]
* sysdeps/i386/fpu/e_log10.S (__ieee754_log10): Take absolute
value when x - 1 is zero.
* sysdeps/i386/fpu/e_log10f.S (__ieee754_log10f): Likewise.
* sysdeps/i386/fpu/e_log10l.S (__ieee754_log10l): Likewise.
* sysdeps/ieee754/ldbl-128/e_log10l.c (__ieee754_log10l): Return
0.0L for an argument of 1.0L.
* sysdeps/ieee754/ldbl-128ibm/e_log10l.c (__ieee754_log10l):
Likewise.
* sysdeps/x86_64/fpu/e_log10l.S (__ieee754_log10l): Take absolute
value when x - 1 is zero.
* math/libm-test.inc (log10_test): Use ALL_RM_TEST.
* sysdeps/i386/fpu/libm-test-ulps: Update.
* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 17 +++++++++++++++++
NEWS | 2 +-
math/libm-test.inc | 4 +---
sysdeps/i386/fpu/e_log10.S | 8 +++++++-
sysdeps/i386/fpu/e_log10f.S | 8 +++++++-
sysdeps/i386/fpu/e_log10l.S | 8 +++++++-
sysdeps/i386/fpu/libm-test-ulps | 24 ++++++++++++++++++++++++
sysdeps/ieee754/ldbl-128/e_log10l.c | 3 +++
sysdeps/ieee754/ldbl-128ibm/e_log10l.c | 3 +++
sysdeps/x86_64/fpu/e_log10l.S | 8 +++++++-
sysdeps/x86_64/fpu/libm-test-ulps | 24 ++++++++++++++++++++++++
11 files changed, 101 insertions(+), 8 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug math/16977] log10 (1) incorrect in round-downward mode
2014-05-22 22:42 [Bug math/16977] New: log10 (1) incorrect in round-downward mode jsm28 at gcc dot gnu.org
2014-05-22 22:43 ` [Bug math/16977] " jsm28 at gcc dot gnu.org
2014-05-23 12:08 ` cvs-commit at gcc dot gnu.org
@ 2014-05-23 12:09 ` jsm28 at gcc dot gnu.org
2014-06-12 19:17 ` fweimer at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2014-05-23 12:09 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16977
Joseph Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.20.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug math/16977] log10 (1) incorrect in round-downward mode
2014-05-22 22:42 [Bug math/16977] New: log10 (1) incorrect in round-downward mode jsm28 at gcc dot gnu.org
` (2 preceding siblings ...)
2014-05-23 12:09 ` jsm28 at gcc dot gnu.org
@ 2014-06-12 19:17 ` fweimer at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: fweimer at redhat dot com @ 2014-06-12 19:17 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16977
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |security-
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-12 19:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 22:42 [Bug math/16977] New: log10 (1) incorrect in round-downward mode jsm28 at gcc dot gnu.org
2014-05-22 22:43 ` [Bug math/16977] " jsm28 at gcc dot gnu.org
2014-05-23 12:08 ` cvs-commit at gcc dot gnu.org
2014-05-23 12:09 ` jsm28 at gcc dot gnu.org
2014-06-12 19:17 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).