[Bug libc/16990] New: ARM: Concurrent TLS descriptor resolution fails

[Bug libc/16990] New: ARM: Concurrent TLS descriptor resolution fails

[will.newton at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16990

            Bug ID: 16990
           Summary: ARM: Concurrent TLS descriptor resolution fails
           Product: glibc
           Version: 2.18
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: will.newton at gmail dot com
                CC: drepper.fsp at gmail dot com
              Host: arm

When building glibc with CFLAGS="-mtls-dialect=gnu2 -O2 -g" nptl/tst-tls3
fails. This is caused by concurrent TLS descriptor resolution occuring and a
bug in the code to handle this situation.

_dl_tlsdesc_resolve_hold restores r2 as it assumes that it is being called in
the same circumstances as _dl_tlsdesc_lazy_resolver, but it is not. The lazy
resolver is called from a stub that pushes r2 whereas _dl_tlsdesc_resolve_hold
is called from the TLS descriptor trampoline which does not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16990] ARM: Concurrent TLS descriptor resolution fails

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16990

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  36ffe7398af5e5daa5745c64a15226d864378738 (commit)
      from  2482ae433a4249495859343ae1fba408300f2c2e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=36ffe7398af5e5daa5745c64a15226d864378738

commit 36ffe7398af5e5daa5745c64a15226d864378738
Author: Will Newton <will.newton@linaro.org>
Date:   Fri May 23 15:24:30 2014 +0100

    ARM: Fix handling of concurrent TLS descriptor resolution

    The current code for handling concurrent resolution says that the
    ABI for _dl_tlsdesc_resolve_hold is the same as that of
    _dl_tlsdesc_lazy_resolver. However _dl_tlsdesc_resolve_hold is
    called from the trampoline directly rather than the lazy resolver
    stub so, for example, r2 has not been pushed so does not needed
    to be restored.

    This fixes an intermittent failure in nptl/tst-tls3 when building
    glibc for arm-linux-gnueabihf with -mtls-dialect=gnu2.

    ChangeLog:

    2014-05-27  Will Newton  <will.newton@linaro.org>

        [BZ #16990]
        * sysdeps/arm/dl-tlsdesc.S (_dl_tlsdesc_resolve_hold): Save
        and restore r2 rather than just restoring.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    6 ++++++
 NEWS                     |    2 +-
 sysdeps/arm/dl-tlsdesc.S |   31 ++++++++++++-------------------
 3 files changed, 19 insertions(+), 20 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16990] ARM: Concurrent TLS descriptor resolution fails

[will.newton at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16990

--- Comment #2 from Will Newton <will.newton at gmail dot com> ---
Fixed in commit 36ffe7398af5e5daa5745c64a15226d864378738

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16990] ARM: Concurrent TLS descriptor resolution fails

[will.newton at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16990

Will Newton <will.newton at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Will Newton <will.newton at gmail dot com> ---
Fixed in commit 36ffe7398af5e5daa5745c64a15226d864378738

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16990] ARM: Concurrent TLS descriptor resolution fails

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16990

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.