[Bug nptl/17058] New: trunk/nptl/tst-setuid2.c:138: possible bad if test ?

[Bug nptl/17058] New: trunk/nptl/tst-setuid2.c:138: possible bad if test ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17058

            Bug ID: 17058
           Summary: trunk/nptl/tst-setuid2.c:138: possible bad if test ?
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com
                CC: drepper.fsp at gmail dot com

[trunk/nptl/tst-setuid2.c:138]: (warning) Logical disjunction always evaluates
to true: euid != 1002 || euid != 1003.

Source code is

  if (ruid != 1001 || euid != 1002 || euid != 1003)
    FAIL ("unexpected UIDs after setuid: %ld, %ld, %ld",
      (long) ruid, (long) euid, (long) suid);

Maybe better code might be

  if (ruid != 1001 || euid != 1002 || suid != 1003)
    FAIL ("unexpected UIDs after setuid: %ld, %ld, %ld",
      (long) ruid, (long) euid, (long) suid);

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17058] trunk/nptl/tst-setuid2.c:138: possible bad if test ?

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17058

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a7291117328b413295ae7d1c841e944bc60062d3 (commit)
      from  3d7c00e3a944e07a74fc1c18e342ed7f38b2d88e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a7291117328b413295ae7d1c841e944bc60062d3

commit a7291117328b413295ae7d1c841e944bc60062d3
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jun 16 18:00:09 2014 +0200

    Fix tautological comparison in non-executed part of tst-setuid2 (BZ #17058)

    This part never runs with the current implementation
    because the setresuid call currently aborts (as intended).

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog          |    6 ++++++
 NEWS               |    2 +-
 nptl/tst-setuid2.c |    2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17058] trunk/nptl/tst-setuid2.c:138: possible bad if test ?

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17058

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed in commit a7291117328b413295ae7d1c841e944bc60062d3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.