From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116042 invoked by alias); 29 Aug 2015 22:20:58 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 115933 invoked by uid 55); 29 Aug 2015 22:20:54 -0000 From: "cvs-commit at gcc dot gnu.org" To: glibc-bugs@sourceware.org Subject: [Bug libc/17273] getmntent() returns wrong default value for fs_passno Date: Sat, 29 Aug 2015 22:20:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.21 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-08/txt/msg00623.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=17273 --- Comment #6 from cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, gentoo/2.21 has been updated via 460e5da421067eb690ba3b9d11183c4b7db37e4f (commit) from 43d7ce9238c59c61003994cb26eff4a6a072ebd5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=460e5da421067eb690ba3b9d11183c4b7db37e4f commit 460e5da421067eb690ba3b9d11183c4b7db37e4f Author: Mike Frysinger Date: Fri Aug 28 17:08:49 2015 -0400 getmntent: fix memory corruption w/blank lines [BZ #18887] The fix for BZ #17273 introduced a single byte of memory corruption when the line is entirely blank. It would walk back past the start of the buffer if the heap happened to be 0x20 or 0x09 and then write a NUL byte. buffer = '\n'; end_ptr = buffer; while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t') end_ptr--; *end_ptr = '\0'; Fix that and rework the tests. Adding the testcase for BZ #17273 to the existing \040 parser does not really make sense as it's unrelated, and leads to confusing behavior: it implicitly relies on the new entry being longer than the previous entry (since it just rewinds the FILE*). Split it out into its own dedicated testcase instead. (cherry picked from commit b0e805fa0d6fea33745952df7b7f5442ca4c374f) (cherry picked from commit f2cdbadd8a078482d3b9fc2b59e888c64cc4efae) ----------------------------------------------------------------------- Summary of changes: misc/Makefile | 3 +- misc/mntent_r.c | 4 +- .../tst-mntent-blank-corrupt.c | 27 +++++++------ .../tst-mntent-blank-passno.c | 40 +++++++++++--------- misc/tst-mntent.c | 20 ---------- 5 files changed, 42 insertions(+), 52 deletions(-) copy libio/test-fmemopen.c => misc/tst-mntent-blank-corrupt.c (60%) copy math/tst-definitions.c => misc/tst-mntent-blank-passno.c (55%) -- You are receiving this mail because: You are on the CC list for the bug.