public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/17273] getmntent() returns wrong default value for fs_passno
Date: Sat, 29 Aug 2015 22:13:00 -0000	[thread overview]
Message-ID: <bug-17273-131-wuOzqttYN1@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-17273-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=17273

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.21/master has been updated
       via  f2cdbadd8a078482d3b9fc2b59e888c64cc4efae (commit)
      from  978908245b2c0f759100708a9966649f7b273664 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f2cdbadd8a078482d3b9fc2b59e888c64cc4efae

commit f2cdbadd8a078482d3b9fc2b59e888c64cc4efae
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Fri Aug 28 17:08:49 2015 -0400

    getmntent: fix memory corruption w/blank lines [BZ #18887]

    The fix for BZ #17273 introduced a single byte of memory corruption when
    the line is entirely blank.  It would walk back past the start of the
    buffer if the heap happened to be 0x20 or 0x09 and then write a NUL byte.
        buffer = '\n';
        end_ptr = buffer;
        while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t')
                end_ptr--;
        *end_ptr = '\0';

    Fix that and rework the tests.  Adding the testcase for BZ #17273 to the
    existing \040 parser does not really make sense as it's unrelated, and
    leads to confusing behavior: it implicitly relies on the new entry being
    longer than the previous entry (since it just rewinds the FILE*).  Split
    it out into its own dedicated testcase instead.

    (cherry picked from commit b0e805fa0d6fea33745952df7b7f5442ca4c374f)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   10 +++++
 NEWS                                               |    2 +-
 misc/Makefile                                      |    3 +-
 misc/mntent_r.c                                    |    4 +-
 .../tst-mntent-blank-corrupt.c                     |   27 +++++++------
 .../tst-mntent-blank-passno.c                      |   40 +++++++++++---------
 misc/tst-mntent.c                                  |   20 ----------
 7 files changed, 53 insertions(+), 53 deletions(-)
 copy libio/test-fmemopen.c => misc/tst-mntent-blank-corrupt.c (60%)
 copy math/tst-definitions.c => misc/tst-mntent-blank-passno.c (55%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-08-29 22:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15  3:52 [Bug libc/17273] New: " naszar at ya dot ru
2014-08-15  3:53 ` [Bug libc/17273] " naszar at ya dot ru
2014-08-15  3:54 ` naszar at ya dot ru
2015-08-28 20:34 ` vapier at gentoo dot org
2015-08-28 20:36 ` vapier at gentoo dot org
2015-08-29 22:11 ` cvs-commit at gcc dot gnu.org
2015-08-29 22:13 ` cvs-commit at gcc dot gnu.org [this message]
2015-08-29 22:16 ` cvs-commit at gcc dot gnu.org
2015-08-29 22:20 ` cvs-commit at gcc dot gnu.org
2015-08-29 22:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-17273-131-wuOzqttYN1@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).