public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "zackw at panix dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/17307] New: Spurious -Wsign-conversion warning with clang-3.5, due to excessively clever glibc <sys/resource.h> Date: Mon, 25 Aug 2014 14:36:00 -0000 [thread overview] Message-ID: <bug-17307-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=17307 Bug ID: 17307 Summary: Spurious -Wsign-conversion warning with clang-3.5, due to excessively clever glibc <sys/resource.h> Product: glibc Version: 2.19 Status: NEW Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: zackw at panix dot com CC: drepper.fsp at gmail dot com This test program ... #define _GNU_SOURCE #include <sys/resource.h> int spurious_sign_conversion_warning(int r, struct rlimit *l) { return setrlimit(r, l); } ... produces a spurious -Wsign-conversion warning when compiled against recent GNU libc's headers: $ clang-3.5 -Wsign-conversion -c setrlimit.c setrlimit.c:6:22: warning: implicit conversion changes signedness: 'int' to '__rlimit_resource_t' (aka 'enum __rlimit_resource') [-Wsign-conversion] return setrlimit(r, l); ~~~~~~~~~ ^ 1 warning generated. The problem is this construct in <sys/resource.h>: /* The X/Open standard defines that all the functions below must use `int' as the type for the first argument. When we are compiling with GNU extensions we change this slightly to provide better error checking. */ #if defined __USE_GNU && !defined __cplusplus typedef enum __rlimit_resource __rlimit_resource_t; typedef enum __rusage_who __rusage_who_t; typedef enum __priority_which __priority_which_t; #else typedef int __rlimit_resource_t; typedef int __rusage_who_t; typedef int __priority_which_t; #endif `enum __rlimit_resource` has no negative values and is therefore (I presume) assigned an unsigned type, triggering the warning. I don't think I should have to work around this in my code. X/Open says the type of `setrlimit`'s first argument is `int`, therefore `RLIM_*` constants should be passed around in `int` variables. Moreover, I don't see that there *is* any workaround available to me in C that wouldn't harm portability to other systems. (A portable program can reasonably want to define `_GNU_SOURCE` in order to take advantage of specific glibc features when available.) I initially filed this as a bug with Debian's glibc ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758911 ) and was asked to file an upstream clang bug inviting them to work with upstream glibc to resolve this in a mutually satisfactory way. That bug report is http://llvm.org/bugs/show_bug.cgi?id=20742 . I am also filing this with you, because I think this is as much libc's fault as it is clang's -- defining `_GNU_SOURCE` should *not* change the signature of standardized functions in a way that is observable to correct code. -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2014-08-25 14:36 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-25 14:36 zackw at panix dot com [this message] 2014-08-25 17:40 ` [Bug libc/17307] " carlos at redhat dot com 2014-08-25 18:54 ` zackw at panix dot com 2014-08-26 3:54 ` bugdal at aerifal dot cx
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17307-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).