public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug localedata/17325] iconv from ccsid 937 to utf-8 access invalid memory Date: Fri, 29 Aug 2014 08:40:00 -0000 [thread overview] Message-ID: <bug-17325-131-tVzPHu0rEg@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-17325-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=17325 Florian Weimer <fweimer at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fweimer at redhat dot com Flags| |security+ --- Comment #1 from Florian Weimer <fweimer at redhat dot com> --- This has application impact and has to be treated as a security bug. Do you know what actually happens? I think it's this: rp2 points to the last range in the _idx array, which corresponds to the ch value of 0xffff. This is intended as a sentinel, but the code proceeds as if it is a real table entry. Do you agree? If this analysis is correct, it means that the only possible out-of-bound indexing happens with ch == 0xffff. I think the patch is incorrect because sizeof doesn't give the array length in elements. It may work by accident, but it's probably better to check for 0xffff explicitly, or rp2->idx being zero. Other conversion modules are affected as well (e.g., ibm1364). -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2014-08-29 8:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-28 17:46 [Bug localedata/17325] New: " azanella at linux dot vnet.ibm.com 2014-08-28 17:46 ` [Bug localedata/17325] " azanella at linux dot vnet.ibm.com 2014-08-29 8:40 ` fweimer at redhat dot com [this message] 2014-08-29 9:37 ` fweimer at redhat dot com 2014-08-29 9:57 ` fweimer at redhat dot com 2014-08-29 12:06 ` azanella at linux dot vnet.ibm.com 2014-08-29 12:18 ` fweimer at redhat dot com 2014-09-02 5:40 ` [Bug localedata/17325] iconv from ccsid 937 to utf-8 access invalid memory (CVE-2014-6040) fweimer at redhat dot com 2014-09-03 17:52 ` cvs-commit at gcc dot gnu.org 2014-09-03 17:56 ` fweimer at redhat dot com 2014-09-05 13:16 ` cvs-commit at gcc dot gnu.org 2015-01-16 16:59 ` cvs-commit at gcc dot gnu.org 2015-01-16 17:03 ` cvs-commit at gcc dot gnu.org 2015-01-29 18:47 ` cvs-commit at gcc dot gnu.org 2015-02-23 14:23 ` cvs-commit at gcc dot gnu.org 2015-02-23 15:02 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17325-131-tVzPHu0rEg@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).