[Bug libc/17571] New: qsort_r namespace

[Bug libc/17571] New: qsort_r namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17571

            Bug ID: 17571
           Summary: qsort_r namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

qsort_r is defined in the same file as qsort, but is not an ISO C function, so
should be a weak alias for __qsort_r.  The uses in getaddrinfo should also call
__qsort_r, since getaddrinfo is a POSIX function and qsort_r isn't.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17571] qsort_r namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17571

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  bef8fd6013f7d398661077340753c745a8939279 (commit)
      from  c52ff39e8ee052e4a57676d65a27f09bd0a859ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bef8fd6013f7d398661077340753c745a8939279

commit bef8fd6013f7d398661077340753c745a8939279
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 12 22:33:41 2014 +0000

    Fix qsort_r namespace (bug 17571).

    qsort_r is defined in the same file as qsort, but is not an ISO C
    function, so should be a weak alias for __qsort_r.  The uses in
    getaddrinfo should also call __qsort_r, since getaddrinfo is a POSIX
    function and qsort_r isn't.  This patch implements this.  Because nscd
    uses the getaddrinfo sources outside libc, as do the tst-rfc3484
    tests, a #define of __qsort_r to qsort_r is added there alongside the
    similar defines for other libc-internal symbols used in getaddrinfo.

    Tested for x86_64 (testsuite, and that disassembly of installed shared
    libraries is unchanged by the patch).

        [BZ #17571]
        * stdlib/msort.c (qsort_r): Rename to __qsort_r and define as weak
        alias of __qsort_r.
        (qsort): Call __qsort_r instead of qsort_r.
        * include/stdlib.h (qsort_r): Do not call libc_hidden_proto.
        (__qsort_r): Declare.  Call libc_hidden_proto.
        * sysdeps/posix/getaddrinfo.c (getaddrinfo): Call __qsort_r
        instead of qsort_r.
        * nscd/gai.c (__qsort_r): Define to qsort_r.
        * posix/tst-rfc3484.c (__qsort_r): Likewise.
        * posix/tst-rfc3484-2.c (__qsort_r): Likewise.
        * posix/tst-rfc3484-3.c (__qsort_r): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                   |   13 +++++++++++++
 NEWS                        |    2 +-
 include/stdlib.h            |    3 ++-
 nscd/gai.c                  |    1 +
 posix/tst-rfc3484-2.c       |    1 +
 posix/tst-rfc3484-3.c       |    1 +
 posix/tst-rfc3484.c         |    1 +
 stdlib/msort.c              |    7 ++++---
 sysdeps/posix/getaddrinfo.c |    4 ++--
 9 files changed, 26 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17571] qsort_r namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17571

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.