[Bug libc/17582] New: __get_nprocs fgets_unlocked namespace

[Bug libc/17582] New: __get_nprocs fgets_unlocked namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17582

            Bug ID: 17582
           Summary: __get_nprocs fgets_unlocked namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

__get_nprocs is called from malloc code, but calls fgets_unlocked, which is not
an ISO C or POSIX function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17582] __get_nprocs fgets_unlocked namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17582

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c4eae75271734f820a7477dbce33f8752af6f003 (commit)
      from  01cad84e1996a6f20bf19609d0554c73f2ee33d5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c4eae75271734f820a7477dbce33f8752af6f003

commit c4eae75271734f820a7477dbce33f8752af6f003
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 12 22:39:36 2014 +0000

    Fix __get_nprocs fgets_unlocked namespace (bug 17582).

    __get_nprocs is called from malloc code, but calls fgets_unlocked,
    which is not an ISO C or POSIX function.  This patch fixes it to call
    a new __fgets_unlocked name instead.

    Note: there are various other uses of fgets_unlocked in glibc's
    libraries, and I haven't yet investigated which others might also be
    problematic (called directly or indirectly from standard functions)
    and so need to change to use __fgets_unlocked.

    Tested for x86_64 (testsuite, and that disassembly of installed shared
    libraries is unchanged by the patch).

        [BZ #17582]
        * libio/iofgets.c [weak_alias && !_IO_MTSAFE_IO]
        (__fgets_unlocked): Add alias of _IO_fgets.  Use libc_hidden_def.
        * libio/iofgets_u.c (fgets_unlocked): Rename to __fgets_unlocked
        and define as weak alias of __fgets_unlocked.  Use
        libc_hidden_weak.
        (__fgets_unlocked): Use libc_hidden_def.
        * include/stdio.h (__fgets_unlocked): Declare.  Use
        libc_hidden_proto.
        * sysdeps/unix/sysv/linux/getsysstats.c (phys_pages_info): Use
        __fgets_unlocked instead of fgets_unlocked.
        * sysdeps/unix/sysv/linux/alpha/getsysstats.c
        (GET_NPROCS_CONF_PARSER): Likewise.
        * sysdeps/unix/sysv/linux/sparc/getsysstats.c
        (GET_NPROCS_CONF_PARSER): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                   |   16 ++++++++++++++++
 NEWS                                        |    2 +-
 include/stdio.h                             |    2 ++
 libio/iofgets.c                             |    2 ++
 libio/iofgets_u.c                           |    6 ++++--
 sysdeps/unix/sysv/linux/alpha/getsysstats.c |    2 +-
 sysdeps/unix/sysv/linux/getsysstats.c       |    2 +-
 sysdeps/unix/sysv/linux/sparc/getsysstats.c |    2 +-
 8 files changed, 28 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17582] __get_nprocs fgets_unlocked namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17582

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.