[Bug libc/17584] New: __getcwd rewinddir namespace

[Bug libc/17584] New: __getcwd rewinddir namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17584

            Bug ID: 17584
           Summary: __getcwd rewinddir namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

__getcwd is called from dcigettext.o (brought in by various ISO C
functionality), but calls rewinddir, which is not an ISO C function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17584] __getcwd rewinddir namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17584

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  2f5c1b000aaeb2c25b1df52453bba8de7f9453e2 (commit)
      from  5a6fa4d7ed465c2f7da9d73004c972519dc2100e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2f5c1b000aaeb2c25b1df52453bba8de7f9453e2

commit 2f5c1b000aaeb2c25b1df52453bba8de7f9453e2
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 12 16:24:16 2014 +0000

    Fix __getcwd rewinddir namespace (bug 17584).

    __getcwd is called from dcigettext.o (brought in by various ISO C
    functionality), but calls rewinddir, which is not an ISO C function.
    This patch makes __getcwd call __rewinddir instead and makes rewinddir
    a weak alias for __rewinddir.

    Since getcwd.c is shared with gnulib (albeit not merged in either
    direction for a long time, and omitted from gnulib's
    config/srclist.txt list of shared files) I put in a #ifndef _LIBC
    define of __rewinddir to rewinddir, although a future merged version
    of getcwd could end up looking significantly different.

    Tested for x86_64 (testsuite, and that disassembly of installed shared
    libraries is unchanged by this patch).

        [BZ #17584]
        * dirent/rewinddir.c (rewinddir): Rename to __rewinddir and define
        as weak alias of __rewinddir.  Don't use libc_hidden_def.
        (__rewinddir): Use libc_hidden_def.
        * sysdeps/mach/hurd/rewinddir.c: Rename to __rewinddir and define
        as weak alias of __rewinddir.  Don't use libc_hidden_def.
        (__rewinddir): Use libc_hidden_def.
        * sysdeps/posix/rewinddir.c: Rename to __rewinddir and define as
        weak alias of __rewinddir.  Don't use libc_hidden_def.
        (__rewinddir): Use libc_hidden_def.
        * include/dirent.h (rewinddir): Don't use libc_hidden_proto.
        (__rewinddir): Use libc_hidden_proto.
        * sysdeps/posix/getcwd.c [!_LIBC] (__rewinddir): Define to
        rewinddir.
        (__getcwd): Use __rewinddir instead of rewinddir.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                     |   16 ++++++++++++++++
 NEWS                          |    2 +-
 dirent/rewinddir.c            |    5 +++--
 include/dirent.h              |    3 ++-
 sysdeps/mach/hurd/rewinddir.c |    5 +++--
 sysdeps/posix/getcwd.c        |    6 +++++-
 sysdeps/posix/rewinddir.c     |    5 +++--
 7 files changed, 33 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17584] __getcwd rewinddir namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17584

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.