[Bug libc/17594] New: strtoll / strtoull namespace for 32-bit

[Bug libc/17594] New: strtoll / strtoull namespace for 32-bit

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17594

            Bug ID: 17594
           Summary: strtoll / strtoull namespace for 32-bit
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

For 32-bit platforms, strtoll and strtoull are strong symbols in libc, but they
are not in ISO C90, and are brought in by references to __strtoll_internal /
__strtoull_internal from scanf.  (For 64-bit platforms, they are properly
weak.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17594] strtoll / strtoull namespace for 32-bit

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17594

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  2a1cfd94a26e0fa96d8f284897213b65c60142d6 (commit)
      from  20ed0d266f2c04f5612e2cedf02ede0d0c152e73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2a1cfd94a26e0fa96d8f284897213b65c60142d6

commit 2a1cfd94a26e0fa96d8f284897213b65c60142d6
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Nov 13 19:50:55 2014 +0000

    Fix strtoll / strtoull namespace for 32-bit (bug 17594).

    For 32-bit platforms, strtoll and strtoull are strong symbols in libc,
    but they are not in ISO C90, and are brought in by references to
    __strtoll_internal / __strtoull_internal from scanf.  (For 64-bit
    platforms, they are properly weak.)  This patch makes them weak for
    32-bit (it has a side-effect of making other symbols weak that don't
    need to be weak, such as strtol, but that's harmless).

    Tested for x86 (testsuite, and that the disassembly of installed
    shared libraries is unchanged by the patch).  This fixes all 120
    unXFAILed FAILs of the new linknamespace tests seen for x86 (in fact,
    there are now seven XPASSes of those tests for x86

    XPASS: conform/POSIX2008/fcntl.h/linknamespace
    XPASS: conform/UNIX98/libgen.h/linknamespace
    XPASS: conform/XOPEN2K/fcntl.h/linknamespace
    XPASS: conform/XOPEN2K/libgen.h/linknamespace
    XPASS: conform/XOPEN2K8/fcntl.h/linknamespace
    XPASS: conform/XOPEN2K8/libgen.h/linknamespace
    XPASS: conform/XPG4/libgen.h/linknamespace

    so suggesting that the failures seen for those on x86_64 are in some
    way architecture-specific or 64-bit-specific).

        [BZ #17594]
        * stdlib/strtol.c (SYM__): New macro.
        (SYM__1): Likewise.
        (__strtol): Likewise.
        (strtol): Rename to __strtol and define as weak alias of
        __strtol.  Use libc_hidden_weak.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog       |    9 +++++++++
 NEWS            |    2 +-
 stdlib/strtol.c |    9 +++++++--
 3 files changed, 17 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17594] strtoll / strtoull namespace for 32-bit

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17594

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.