[Bug libc/17668] New: getifaddrs, freeifaddrs namespace

[Bug libc/17668] New: getifaddrs, freeifaddrs namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17668

            Bug ID: 17668
           Summary: getifaddrs, freeifaddrs namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

Various objects in glibc bring in ifaddrs.o (via references to __netlink_*) and
thereby getifaddrs and freeifaddrs, which are not part of any standard
supported by glibc.  These should be weak aliases of __getifaddrs and
__freeifaddrs.  E.g.:

[initial] pthread_create -> [libpthread.a(pthread_create.o)] __resp ->
[libc.a(res_libc.o)] __res_iclose -> [libc.a(res_init.o)] if_nametoindex ->
[libc.a(if_index.o)] __netlink_close -> [libc.a(ifaddrs.o)] freeifaddrs

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17668] getifaddrs, freeifaddrs namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17668

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17668] getifaddrs, freeifaddrs namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17668

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  7f994279e900954f2b220a02fa01f2042eef74b1 (commit)
      from  bbe4c142b024d639418069b480b0f3d05b489803 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7f994279e900954f2b220a02fa01f2042eef74b1

commit 7f994279e900954f2b220a02fa01f2042eef74b1
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Dec 2 23:11:09 2014 +0000

    Fix getifaddrs, freeifaddrs namespace (bug 17668).

    Various objects in glibc bring in ifaddrs.o (via references to
    __netlink_*) and thereby getifaddrs and freeifaddrs, which are not
    part of any standard supported by glibc.  These should be weak aliases
    of __getifaddrs and __freeifaddrs; this patch makes them so.

    (The path by which these functions are brought in is Linux-specific,
    but it seems less confusing to make all versions of these functions
    weak aliases rather than only the Linux-specific versions that
    definitely need it.)

    Tested for x86_64 (testsuite, and that disassembly of installed shared
    libraries is unchanged by this patch).

        [BZ #17668]
        * inet/ifaddrs.c (getifaddrs): Rename to __getifaddrs and define
        as weak alias of __getifaddrs.  Use libc_hidden_weak.
        (freeifaddrs): Rename to __freeifaddrs and define as weak alias of
        __freeifaddrs.  Use libc_hidden_weak.
        * sysdeps/gnu/ifaddrs.c (getifaddrs): Rename to __getifaddrs and
        define as weak alias of __getifaddrs.  Use libc_hidden_weak.
        (freeifaddrs): Rename to __freeifaddrs and define as weak alias of
        __freeifaddrs.  Use libc_hidden_weak.
        * sysdeps/unix/sysv/linux/ifaddrs.c (getifaddrs): Rename to
        __getifaddrs and define as weak alias of __getifaddrs.  Use
        libc_hidden_weak.
        (freeifaddrs): Rename to __freeifaddrs and define as weak alias of
        __freeifaddrs.  Use libc_hidden_weak.
        * conform/Makefile (test-xfail-XOPEN2K/net/if.h/linknamespace):
        Remove variable.
        (test-xfail-POSIX2008/net/if.h/linknamespace): Likewise.
        (test-xfail-XOPEN2K8/net/if.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |   21 +++++++++++++++++++++
 NEWS                              |    2 +-
 conform/Makefile                  |    3 ---
 inet/ifaddrs.c                    |   10 ++++++----
 sysdeps/gnu/ifaddrs.c             |   10 ++++++----
 sysdeps/unix/sysv/linux/ifaddrs.c |   10 ++++++----
 6 files changed, 40 insertions(+), 16 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.