[Bug libc/17672] New: Signature for Linux Syscall sync_file_range Has Misleading (non-Spec) Names

[Bug libc/17672] New: Signature for Linux Syscall sync_file_range Has Misleading (non-Spec) Names

[bj at wjblack dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17672

            Bug ID: 17672
           Summary: Signature for Linux Syscall sync_file_range Has
                    Misleading (non-Spec) Names
           Product: glibc
           Version: 2.20
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: bj at wjblack dot com
                CC: drepper.fsp at gmail dot com

Created attachment 7986
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7986&action=edit
Patch to Change Misleading Names of Parameters of sync_file_range

Hi there!

According to the man page and the linux sources, the signature for
sync_file_range is:

--cut here--
int sync_file_range(int fd, off64_t offset, off64_t nbytes,
                    unsigned int flags);
--cut here--

(Source: http://linux.die.net/man/2/sync_file_range, confirmed in the
kernel.org sources for Linux 3.17 in fs/sync.c (syscall definition for
sync_file_range))

glibc, however, has scattered definitions of the form:

--cut here--
int
sync_file_range (int fd, __off64_t from, __off64_t to, unsigned int flags)
{
--cut here--

...which, while it technically works, is confusing as hell (offset/bytes
implies different functionality than from/to).

I've attached a patch against git as of now (Dec 2).  It looks like a similar
identifier mismatch was fixed elsewhere in glibc back in ye olde days of yore
(ca 2009):

https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=424bea69fb3bcad456162da4a87ff6b558baaa8a

Thanks!
--bj

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17672] Signature for Linux Syscall sync_file_range Has Misleading (non-Spec) Names

[bj at wjblack dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17672

BJ Black <bj at wjblack dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3
                 CC|                            |bj at wjblack dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.