public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/17672] New: Signature for Linux Syscall sync_file_range Has Misleading (non-Spec) Names
@ 2014-12-02 23:39 bj at wjblack dot com
2014-12-02 23:43 ` [Bug libc/17672] " bj at wjblack dot com
0 siblings, 1 reply; 2+ messages in thread
From: bj at wjblack dot com @ 2014-12-02 23:39 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=17672
Bug ID: 17672
Summary: Signature for Linux Syscall sync_file_range Has
Misleading (non-Spec) Names
Product: glibc
Version: 2.20
Status: NEW
Severity: enhancement
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: bj at wjblack dot com
CC: drepper.fsp at gmail dot com
Created attachment 7986
--> https://sourceware.org/bugzilla/attachment.cgi?id=7986&action=edit
Patch to Change Misleading Names of Parameters of sync_file_range
Hi there!
According to the man page and the linux sources, the signature for
sync_file_range is:
--cut here--
int sync_file_range(int fd, off64_t offset, off64_t nbytes,
unsigned int flags);
--cut here--
(Source: http://linux.die.net/man/2/sync_file_range, confirmed in the
kernel.org sources for Linux 3.17 in fs/sync.c (syscall definition for
sync_file_range))
glibc, however, has scattered definitions of the form:
--cut here--
int
sync_file_range (int fd, __off64_t from, __off64_t to, unsigned int flags)
{
--cut here--
...which, while it technically works, is confusing as hell (offset/bytes
implies different functionality than from/to).
I've attached a patch against git as of now (Dec 2). It looks like a similar
identifier mismatch was fixed elsewhere in glibc back in ye olde days of yore
(ca 2009):
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=424bea69fb3bcad456162da4a87ff6b558baaa8a
Thanks!
--bj
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-02 23:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-02 23:39 [Bug libc/17672] New: Signature for Linux Syscall sync_file_range Has Misleading (non-Spec) Names bj at wjblack dot com
2014-12-02 23:43 ` [Bug libc/17672] " bj at wjblack dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).