[Bug nptl/17682] New: pthreads getrlimit, gettimeofday namespace

[Bug nptl/17682] New: pthreads getrlimit, gettimeofday namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17682

            Bug ID: 17682
           Summary: pthreads getrlimit, gettimeofday namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

Some pthreads functions use getrlimit and gettimeofday, but these functions are
XSI, not base POSIX.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17682] pthreads getrlimit, gettimeofday namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17682

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c5c2b7c3fd823fc5c4a52506292a90eba60b0c62 (commit)
      from  9752c3cdbce2b3b8338abf09c8b9dd9e78908b8a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c5c2b7c3fd823fc5c4a52506292a90eba60b0c62

commit c5c2b7c3fd823fc5c4a52506292a90eba60b0c62
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Sat Dec 6 23:40:48 2014 +0000

    Fix pthreads getrlimit, gettimeofday namespace (bug 17682).

    Some pthreads functions use getrlimit and gettimeofday, but these
    functions are XSI, not base POSIX; this is a namespace issue for
    dynamic linking as well as static linking.  This patch makes them use
    __getrlimit and __gettimeofday instead - the former needed to be newly
    exported from libc.so at GLIBC_PRIVATE (and so now needs
    libc_hidden_proto / libc_hidden_def), the latter was already exported.

    Tested for x86_64 (testsuite, and that disassembly of installed shared
    libraries is unchanged by the patch).

        [BZ #17682]
        * resource/Versions (libc): Add __getrlimit at GLIBC_PRIVATE.
        * resource/getrlimit.c (__getrlimit): Use libc_hidden_def.
        * sysdeps/mach/hurd/getrlimit.c (__getrlimit): Likewise.
        * include/sys/resource.h (__getrlimit): Use libc_hidden_proto.
        * nptl/nptl-init.c (__pthread_initialize_minimal_internal): Use
        __getrlimit instead of getrlimit.
        * nptl/pthread_cond_timedwait.c (__pthread_cond_timedwait): Use
        __gettimeofday instead of gettimeofday.
        * nptl/pthread_rwlock_timedrdlock.c (pthread_rwlock_timedrdlock):
        Likewise.
        * nptl/pthread_rwlock_timedwrlock.c (pthread_rwlock_timedwrlock):
        Likewise.
        * sysdeps/pthread/aio_misc.c (handle_fildes_io): Likewise.
        * conform/Makefile (test-xfail-POSIX2008/aio.h/linknamespace):
        Remove variable.
        (test-xfail-POSIX2008/pthread.h/linknamespace): Likewise.
        (test-xfail-POSIX2008/time.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |   21 +++++++++++++++++++++
 NEWS                              |    3 ++-
 conform/Makefile                  |    3 ---
 include/sys/resource.h            |    1 +
 nptl/nptl-init.c                  |    2 +-
 nptl/pthread_cond_timedwait.c     |    2 +-
 nptl/pthread_rwlock_timedrdlock.c |    2 +-
 nptl/pthread_rwlock_timedwrlock.c |    2 +-
 resource/Versions                 |    3 +++
 resource/getrlimit.c              |    1 +
 sysdeps/mach/hurd/getrlimit.c     |    1 +
 sysdeps/pthread/aio_misc.c        |    2 +-
 12 files changed, 34 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17682] pthreads getrlimit, gettimeofday namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17682

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.