public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/17711] copy relocations against protected symbols don't work Date: Tue, 31 Mar 2015 12:17:00 -0000 [thread overview] Message-ID: <bug-17711-131-gdIzJD9uCP@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-17711-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=17711 --- Comment #21 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via 62da1e3b00b51383ffa7efc89d8addda0502e107 (commit) from 675ddb7184f642263331b13ac7bf726536504f97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62da1e3b00b51383ffa7efc89d8addda0502e107 commit 62da1e3b00b51383ffa7efc89d8addda0502e107 Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Mar 31 05:15:43 2015 -0700 Add ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA to x86 With copy relocation, address of protected data defined in the shared library may be external. When there is a relocation against the protected data symbol within the shared library, we need to check if we should skip the definition in the executable copied from the protected data. This patch adds ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA and defines it for x86. If ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA isn't 0, do_lookup_x will skip the data definition in the executable from copy reloc. [BZ #17711] * elf/dl-lookup.c (do_lookup_x): When UNDEF_MAP is NULL, which indicates it is called from do_lookup_x on relocation against protected data, skip the data definion in the executable from copy reloc. (_dl_lookup_symbol_x): Pass ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA, instead of ELF_RTYPE_CLASS_PLT, to do_lookup_x for EXTERN_PROTECTED_DATA relocation against STT_OBJECT symbol. * sysdeps/generic/ldsodefs.h * (ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA): New. Defined to 4 if DL_EXTERN_PROTECTED_DATA is defined, otherwise to 0. * sysdeps/i386/dl-lookupcfg.h (DL_EXTERN_PROTECTED_DATA): New. * sysdeps/i386/dl-machine.h (elf_machine_type_class): Set class to ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA for R_386_GLOB_DAT. * sysdeps/x86_64/dl-lookupcfg.h (DL_EXTERN_PROTECTED_DATA): New. * sysdeps/x86_64/dl-machine.h (elf_machine_type_class): Set class to ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA for R_X86_64_GLOB_DAT. ----------------------------------------------------------------------- Summary of changes: ChangeLog | 20 +++++++++++++ elf/dl-lookup.c | 61 ++++++++++++++++++++++++++++++++++++++++- sysdeps/generic/ldsodefs.h | 12 +++++++- sysdeps/i386/dl-lookupcfg.h | 4 +++ sysdeps/i386/dl-machine.h | 8 ++++- sysdeps/x86_64/dl-lookupcfg.h | 4 +++ sysdeps/x86_64/dl-machine.h | 8 ++++- 7 files changed, 111 insertions(+), 6 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2015-03-31 12:17 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-14 12:43 [Bug dynamic-link/17711] New: " hjl.tools at gmail dot com 2014-12-14 15:05 ` Ondřej Bílka 2014-12-14 15:06 ` [Bug dynamic-link/17711] " neleai at seznam dot cz 2014-12-14 15:14 ` hjl.tools at gmail dot com 2014-12-14 20:24 ` hjl.tools at gmail dot com 2014-12-15 0:58 ` hjl.tools at gmail dot com 2014-12-17 16:27 ` hjl.tools at gmail dot com 2014-12-17 21:25 ` hjl.tools at gmail dot com 2015-02-27 21:25 ` hjl.tools at gmail dot com 2015-02-27 22:14 ` cvs-commit at gcc dot gnu.org 2015-02-27 22:16 ` hjl.tools at gmail dot com 2015-03-05 23:20 ` hjl.tools at gmail dot com 2015-03-05 23:50 ` cvs-commit at gcc dot gnu.org 2015-03-06 12:59 ` cvs-commit at gcc dot gnu.org 2015-03-06 13:02 ` cvs-commit at gcc dot gnu.org 2015-03-06 19:39 ` cvs-commit at gcc dot gnu.org 2015-03-06 21:26 ` cvs-commit at gcc dot gnu.org 2015-03-06 22:56 ` hjl.tools at gmail dot com 2015-03-06 23:43 ` cvs-commit at gcc dot gnu.org 2015-03-07 0:59 ` cvs-commit at gcc dot gnu.org 2015-03-07 1:08 ` cvs-commit at gcc dot gnu.org 2015-03-07 14:26 ` cvs-commit at gcc dot gnu.org 2015-03-27 17:21 ` hjl.tools at gmail dot com 2015-03-31 12:17 ` cvs-commit at gcc dot gnu.org [this message] 2015-03-31 12:22 ` cvs-commit at gcc dot gnu.org 2015-04-01 0:02 ` cvs-commit at gcc dot gnu.org 2015-04-01 0:05 ` cvs-commit at gcc dot gnu.org 2015-04-01 0:07 ` cvs-commit at gcc dot gnu.org 2015-04-01 0:19 ` cvs-commit at gcc dot gnu.org 2015-04-01 0:28 ` cvs-commit at gcc dot gnu.org 2015-07-11 19:46 ` neleai at seznam dot cz 2015-07-24 9:08 ` cvs-commit at gcc dot gnu.org 2015-08-02 3:55 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17711-131-gdIzJD9uCP@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).