public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug math/17724] New: __rintl namespace
@ 2014-12-17 16:25 schwab@linux-m68k.org
  2014-12-22 18:47 ` [Bug math/17724] " cvs-commit at gcc dot gnu.org
  2014-12-22 18:47 ` jsm28 at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: schwab@linux-m68k.org @ 2014-12-17 16:25 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=17724

            Bug ID: 17724
           Summary: __rintl namespace
           Product: glibc
           Version: 2.20
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: schwab@linux-m68k.org

sysdeps/ieee754/ldbl-128ibm/s_rintl.c is calling fesetround which is not in
C89, but __rintl is called by __kernel_standard which is called by acos.

[initial] __acos -> [libm.a(w_acos.o)] __kernel_standard ->
[libm.a(k_standard.o)] __rintl -> [libm.a(s_rintl.o)] fesetround

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug math/17724] __rintl namespace
  2014-12-17 16:25 [Bug math/17724] New: __rintl namespace schwab@linux-m68k.org
  2014-12-22 18:47 ` [Bug math/17724] " cvs-commit at gcc dot gnu.org
@ 2014-12-22 18:47 ` jsm28 at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2014-12-22 18:47 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=17724

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug math/17724] __rintl namespace
  2014-12-17 16:25 [Bug math/17724] New: __rintl namespace schwab@linux-m68k.org
@ 2014-12-22 18:47 ` cvs-commit at gcc dot gnu.org
  2014-12-22 18:47 ` jsm28 at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2014-12-22 18:47 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=17724

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f56f91245a0a5aa0facaa14b5608cfb761df7c38 (commit)
      from  9d1fc928a4c3ab15b46945b0abdf7054a75cc010 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f56f91245a0a5aa0facaa14b5608cfb761df7c38

commit f56f91245a0a5aa0facaa14b5608cfb761df7c38
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Dec 22 18:45:50 2014 +0000

    Split __kernel_standard* functions (fixes bug 17724).

    Bug 17724 reports references to fesetround being brought in by
    ldbl-128ibm rintl via references to __rintl from __kernel_standard_l.
    Because all three __kernel_standard* functions are in the same file,
    this gets brought in even though only the long double version
    __kernel_standard_l needs __rintl, and the C90 functions use only
    __kernel_standard.

    This patch fixes this by splitting the three versions into separate
    files; it's fine for long double functions to refer to fe* functions
    directly, unless they get called by C90 double functions.

    Tested for x86_64 (testsuite; the reordering of code means disassembly
    of shared libraries can't usefully be compared).  Tested for powerpc
    that the relevant issue disappears from the linknamespace test
    output.

        [BZ #17724]
        * sysdeps/ieee754/k_standard.c: Don't include <float.h>.
        (__kernel_standard_f): Remove.  Moved to k_standardf.c.
        (__kernel_standard_l): Remove.  Moved to k_standardl.c with
        (char *) casts added.
        * sysdeps/ieee754/k_standardf.c: New file.
        * sysdeps/ieee754/k_standardl.c: Likewise.
        * math/Makefile (libm-support): Remove k_standard.
        (libm-calls): Add k_standard.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   12 ++
 NEWS                                               |    2 +-
 math/Makefile                                      |    4 +-
 sysdeps/ieee754/k_standard.c                       |   90 --------------
 iconvdata/cp770.c => sysdeps/ieee754/k_standardf.c |   19 ++--
 sysdeps/ieee754/k_standardl.c                      |  123 ++++++++++++++++++++
 6 files changed, 149 insertions(+), 101 deletions(-)
 copy iconvdata/cp770.c => sysdeps/ieee754/k_standardf.c (68%)
 create mode 100644 sysdeps/ieee754/k_standardl.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-22 18:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 16:25 [Bug math/17724] New: __rintl namespace schwab@linux-m68k.org
2014-12-22 18:47 ` [Bug math/17724] " cvs-commit at gcc dot gnu.org
2014-12-22 18:47 ` jsm28 at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).