public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "egmont at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug localedata/17750] wrong collation order of diacritics in most locales
Date: Tue, 08 Sep 2015 08:50:00 -0000	[thread overview]
Message-ID: <bug-17750-131-R2d68dqycI@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-17750-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=17750

Egmont Koblinger <egmont at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egmont at gmail dot com

--- Comment #11 from Egmont Koblinger <egmont at gmail dot com> ---
This change broke (among others) the Hungarian locales (see 18934).

I totally agree with Alexandre's opinion (the assumptions made by the patch
being wrong on so many levels); extending with a fifth one:

Even if there are some French words present in a list, if you're using a
certain language then the alphabetical rules of that language should apply, not
the French one. This is what locale definitions are about. Define in the French
locales the way to sort words on a French UI, but please leave the other
locales alone.

I'm disappointed that such a change that was doomed to break so many locales
managed to make it into glibc. But I think that in the end it boils down to the
lack of proper unittest coverage.

In the above mentioned bug I created an extensive unittest for Hungarian, one
that points to the official rules of alphabetical sorting and takes the
examples from that (plus many more), and would have failed with this change.

I encourage maintainers of locale files to come up with similarly extensive
unittests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-09-08  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23  4:25 [Bug localedata/17750] New: " aoliva at sourceware dot org
2014-12-23  5:34 ` [Bug localedata/17750] " aoliva at sourceware dot org
2014-12-23 18:12 ` keld at keldix dot com
2015-01-29 13:17 ` fweimer at redhat dot com
2015-01-29 14:35 ` carlos at redhat dot com
2015-01-30 15:25 ` keld at keldix dot com
2015-01-30 17:52 ` carlos at redhat dot com
2015-09-08  8:50 ` egmont at gmail dot com [this message]
2015-09-08  8:52 ` egmont at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-17750-131-R2d68dqycI@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).