[Bug nptl/17870] New: Build failure on x32

[Bug nptl/17870] New: Build failure on x32

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17870

            Bug ID: 17870
           Summary: Build failure on x32
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com

With commit 2ec2d7032ff9220da1577c37d41ae85c0721ad66 on x32, I got

In file included from sem_timedwait.c:20:0:
sem_waitcommon.c: In function ‘__sem_wait_cleanup’:
sem_waitcommon.c:190:3: error: left shift count >= width of type [-Werror]
   atomic_fetch_add_relaxed (&sem->data, -(1UL << SEM_NWAITERS_SHIFT));
   ^
sem_waitcommon.c: In function ‘__new_sem_wait_slow’:
sem_waitcommon.c:266:3: error: left shift count >= width of type [-Werror]
   unsigned long d = atomic_fetch_add_relaxed (&sem->data,
   ^
sem_waitcommon.c:306:8: error: left shift count >= width of type [-Werror]
        atomic_fetch_add_relaxed (&sem->data,
        ^
sem_waitcommon.c:322:4: error: left shift count >= width of type [-Werror]
    if (atomic_compare_exchange_weak_acquire (&sem->data,
    ^

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From glibc-bugs-return-27153-listarch-glibc-bugs=sources.redhat.com@sourceware.org Fri Jan 23 22:02:41 2015
Return-Path: <glibc-bugs-return-27153-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-glibc-bugs@sources.redhat.com
Received: (qmail 3255 invoked by alias); 23 Jan 2015 22:02:41 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Delivered-To: mailing list glibc-bugs@sourceware.org
Received: (qmail 3218 invoked by uid 48); 23 Jan 2015 22:02:37 -0000
From: "hjl.tools at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug nptl/17870] Build failure on x32
Date: Fri, 23 Jan 2015 22:02:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: nptl
X-Bugzilla-Version: 2.21
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-17870-131-0z3Nm6FFSl@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-17870-131@http.sourceware.org/bugzilla/>
References: <bug-17870-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg00178.txt.bz2
Content-length: 938

https://sourceware.org/bugzilla/show_bug.cgi?id\x17870

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
It is caused by

commit 042e1521c794a945edc43b5bfa7e69ad70420524
Author: Carlos O'Donell <carlos@systemhalted.org>
Date:   Wed Jan 21 00:46:16 2015 -0500

    Fix semaphore destruction (bug 12674).

    This commit fixes semaphore destruction by either using 64b atomic
    operations (where available), or by using two separate fields when only
    32b atomic operations are available.  In the latter case, we keep a
    conservative estimate of whether there are any waiting threads in one
    bit of the field that counts the number of available tokens, thus
    allowing sem_post to atomically both add a token and determine whether
    it needs to call futex_wake.

    See:
    https://sourceware.org/ml/libc-alpha/2014-12/msg00155.html

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17870] Build failure on x32

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17870

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com
           Assignee|unassigned at sourceware dot org   |carlos at redhat dot com

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
I'm looking at this with Torvald's help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17870] Build failure on x32

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17870

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  22971c35e2de34ec3e1b02e9bceebcba2ead7bfe (commit)
      from  2ec2d7032ff9220da1577c37d41ae85c0721ad66 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=22971c35e2de34ec3e1b02e9bceebcba2ead7bfe

commit 22971c35e2de34ec3e1b02e9bceebcba2ead7bfe
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Jan 23 14:48:40 2015 -0800

    Use uint64_t and (uint64_t) 1 for 64-bit int

    This patch replaces unsigned long int and 1UL with uint64_t and
    (uint64_t) 1 to support ILP32 targets like x32.

        [BZ #17870]
        * nptl/sem_post.c (__new_sem_post): Replace unsigned long int
        with uint64_t.
        * nptl/sem_waitcommon.c (__sem_wait_cleanup): Replace 1UL with
        (uint64_t) 1.
        (__new_sem_wait_slow): Replace unsigned long int with uint64_t.
        Replace 1UL with (uint64_t) 1.
        * sysdeps/nptl/internaltypes.h (new_sem): Replace unsigned long
        int with uint64_t.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                    |   12 ++++++++++++
 NEWS                         |    2 +-
 nptl/sem_post.c              |    2 +-
 nptl/sem_waitcommon.c        |   10 +++++-----
 sysdeps/nptl/internaltypes.h |    2 +-
 5 files changed, 20 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/17870] Build failure on x32

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17870

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.21

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.