public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "konstantin.s.serebryany at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18043] buffer-overflow (read past the end) in wordexp/parse_dollars/parse_param
Date: Mon, 09 Mar 2015 06:21:00 -0000	[thread overview]
Message-ID: <bug-18043-131-tgOTULi7L6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18043-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=18043

Kostya Serebryany <konstantin.s.serebryany at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from Kostya Serebryany <konstantin.s.serebryany at gmail dot com> ---
Thanks for the fix. There is one more, very similar looking bug, 
but it still reproduces after your fix. 

#include <wordexp.h>
#include <string.h>
int main() {
  char *p = strdup("L${a:");
  wordexp_t w;
  wordexp(p, &w, 0);
}

==26576== Invalid read of size 1
==26576==    at 0x4F1DEB4: parse_param (wordexp.c:1366)
==26576==    by 0x4F1DEB4: parse_dollars (wordexp.c:2102)
==26576==    by 0x4F1FFEB: wordexp (wordexp.c:2348)
==26576==    by 0x4005AA: main (we4.c:6)
==26576==  Address 0x51fb046 is 0 bytes after a block of size 6 alloc'd
==26576==    at 0x4C2ABBD: malloc (vg_replace_malloc.c:296)
==26576==    by 0x4EBE839: strdup (strdup.c:42)
==26576==    by 0x40058E: main (we4.c:4)
==26576== 

(reopening this bug instead of creating a new one for simplicity)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-03-09  6:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 23:10 [Bug libc/18043] New: " konstantin.s.serebryany at gmail dot com
2015-02-28  3:49 ` [Bug libc/18043] " ppluzhnikov at google dot com
2015-03-06 17:14 ` cvs-commit at gcc dot gnu.org
2015-03-06 17:16 ` ppluzhnikov at google dot com
2015-03-09  4:39 ` cvs-commit at gcc dot gnu.org
2015-03-09  6:21 ` konstantin.s.serebryany at gmail dot com [this message]
2015-03-09 14:25 ` cvs-commit at gcc dot gnu.org
2015-03-09 14:28 ` ppluzhnikov at google dot com
2015-03-09 16:42 ` konstantin.s.serebryany at gmail dot com
2015-03-09 17:55 ` konstantin.s.serebryany at gmail dot com
2015-03-09 18:20 ` ppluzhnikov at google dot com
2015-03-09 18:39 ` konstantin.s.serebryany at gmail dot com
2015-03-09 18:47 ` konstantin.s.serebryany at gmail dot com
2015-03-09 18:51 ` ppluzhnikov at google dot com
2015-03-09 19:09 ` konstantin.s.serebryany at gmail dot com
2015-03-09 19:10 ` konstantin.s.serebryany at gmail dot com
2015-03-09 19:22 ` ppluzhnikov at google dot com
2015-03-09 19:28 ` konstantin.s.serebryany at gmail dot com
2015-03-09 22:25 ` ppluzhnikov at google dot com
2015-03-09 22:35 ` konstantin.s.serebryany at gmail dot com
2015-03-09 23:16 ` ppluzhnikov at google dot com
2015-03-11 15:57 ` cvs-commit at gcc dot gnu.org
2015-03-11 16:01 ` ppluzhnikov at google dot com
2015-03-19 14:55 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18043-131-tgOTULi7L6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).