From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-27795-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 97061 invoked by alias); 9 Mar 2015 19:22:28 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Received: (qmail 97003 invoked by uid 48); 9 Mar 2015 19:22:24 -0000
From: "ppluzhnikov at google dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18043] buffer-overflow (read past the end) in wordexp/parse_dollars/parse_param
Date: Mon, 09 Mar 2015 19:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.21
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ppluzhnikov at google dot com
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: ppluzhnikov at google dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: security+
X-Bugzilla-Changed-Fields:
Message-ID: <bug-18043-131-wVcJvFiBJO@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-18043-131@http.sourceware.org/bugzilla/>
References: <bug-18043-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg00088.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=18043

--- Comment #15 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
(In reply to Kostya Serebryany from comment #14)
> same happens with 
>   setenv("Ca", "", 1);

This one is not reproducing for me with either 2.19 or trunk.

OTOH, with test from comment #13, both from glibc-2.19 and trunk give me two
separate overflows:

==3325== Invalid read of size 1
==3325==    at 0x48EBF9E: parse_dollars (/glibc-git/posix/wordexp.c:1573)
==3325==    by 0x48ED3CA: wordexp (/glibc-git/posix/wordexp.c:2352)
==3325==    by 0x400613: main (/tmp/t.c:8)
==3325==  Address 0x4bb62d3 is 0 bytes after a block of size 3 alloc'd
==3325==    at 0x480B7C4: malloc
(valgrind/coregrind/m_replacemalloc/vg_replace_malloc.c:270)
==3325==    by 0x484A6F6: __add_to_environ (/glibc-git/stdlib/setenv.c:202)
==3325==    by 0x480F4BF: setenv (valgrind/memcheck/mc_replace_strmem.c:1643)
==3325==    by 0x4005ED: main (/tmp/t.c:5)
==3325==
==3325== Invalid read of size 1
==3325==    at 0x48EBD15: parse_dollars (/glibc-git/posix/wordexp.c:1897)
==3325==    by 0x48ED3CA: wordexp (/glibc-git/posix/wordexp.c:2352)
==3325==    by 0x400613: main (/tmp/t.c:8)
==3325==  Address 0x4bb62d3 is 0 bytes after a block of size 3 alloc'd
==3325==    at 0x480B7C4: malloc
(valgrind/coregrind/m_replacemalloc/vg_replace_malloc.c:270)
==3325==    by 0x484A6F6: __add_to_environ (/glibc-git/stdlib/setenv.c:202)
==3325==    by 0x480F4BF: setenv (valgrind/memcheck/mc_replace_strmem.c:1643)
==3325==    by 0x4005ED: main (/tmp/t.c:5)

Thanks for the test!

-- 
You are receiving this mail because:
You are on the CC list for the bug.