public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug dynamic-link/18251] New: SONAME missing when audit modules provides path
@ 2015-04-10 22:46 drepper.fsp at gmail dot com
2015-04-12 13:05 ` [Bug dynamic-link/18251] " drepper.fsp at gmail dot com
2015-04-12 16:01 ` drepper.fsp at gmail dot com
0 siblings, 2 replies; 3+ messages in thread
From: drepper.fsp at gmail dot com @ 2015-04-10 22:46 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=18251
Bug ID: 18251
Summary: SONAME missing when audit modules provides path
Product: glibc
Version: 2.21
Status: NEW
Severity: normal
Priority: P2
Component: dynamic-link
Assignee: unassigned at sourceware dot org
Reporter: drepper.fsp at gmail dot com
Created attachment 8240
--> https://sourceware.org/bugzilla/attachment.cgi?id=8240&action=edit
patch including test case
When audit modules provide path as the return value of the la_objsearch calls
the name replaces whatever ld.so uses to find the DSO. If the target DSO has
an SONAME this is the SONAME. As a result the SONAME is not in the list by
which the DSO is known. This usually is no problem. It becomes a problem when
the SONAME is needed afterwards. One example is checking symbol and DSO
versions.
The patch fixes the problem and contains a patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug dynamic-link/18251] SONAME missing when audit modules provides path
2015-04-10 22:46 [Bug dynamic-link/18251] New: SONAME missing when audit modules provides path drepper.fsp at gmail dot com
@ 2015-04-12 13:05 ` drepper.fsp at gmail dot com
2015-04-12 16:01 ` drepper.fsp at gmail dot com
1 sibling, 0 replies; 3+ messages in thread
From: drepper.fsp at gmail dot com @ 2015-04-12 13:05 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=18251
Ulrich Drepper <drepper.fsp at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8240|0 |1
is obsolete| |
--- Comment #1 from Ulrich Drepper <drepper.fsp at gmail dot com> ---
Created attachment 8243
--> https://sourceware.org/bugzilla/attachment.cgi?id=8243&action=edit
Corrected patch and test
The original patch wasn't complete. It did not take into account that instead
of the SONAME another name (the full path name, for instance) is used. This
requires a more complete handling.
The patch now keeps track of the original name. If an audit module overwrites
the name, the original name is also added to the name list. The impact is
minimal.
I did not optimize out the additional parameter to _dl_map_object_from_fd in
case of static linking. It's not needed, the code checks that it's always
NULL. Removing the parameter would mean uglifying the code a lot. Ideally the
compiler will clone the function (it should be local after all) and in the
clone remove the unnecessary parameter.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug dynamic-link/18251] SONAME missing when audit modules provides path
2015-04-10 22:46 [Bug dynamic-link/18251] New: SONAME missing when audit modules provides path drepper.fsp at gmail dot com
2015-04-12 13:05 ` [Bug dynamic-link/18251] " drepper.fsp at gmail dot com
@ 2015-04-12 16:01 ` drepper.fsp at gmail dot com
1 sibling, 0 replies; 3+ messages in thread
From: drepper.fsp at gmail dot com @ 2015-04-12 16:01 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=18251
Ulrich Drepper <drepper.fsp at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8243|0 |1
is obsolete| |
--- Comment #2 from Ulrich Drepper <drepper.fsp at gmail dot com> ---
Created attachment 8244
--> https://sourceware.org/bugzilla/attachment.cgi?id=8244&action=edit
Complete patch with test and now logging support
One more change: the actions of the audit module in replacing file names can so
far only indirectly be observed, unlike most other actions of the dynamic
linker. In this version of the patch the action is logged in case debugging is
enabled.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-12 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-10 22:46 [Bug dynamic-link/18251] New: SONAME missing when audit modules provides path drepper.fsp at gmail dot com
2015-04-12 13:05 ` [Bug dynamic-link/18251] " drepper.fsp at gmail dot com
2015-04-12 16:01 ` drepper.fsp at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).