public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "nszabolcs at gmail dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/18396] New: timezone internal code for time_t_max and time_t_min is UB Date: Mon, 11 May 2015 17:05:00 -0000 [thread overview] Message-ID: <bug-18396-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=18396 Bug ID: 18396 Summary: timezone internal code for time_t_max and time_t_min is UB Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: nszabolcs at gmail dot com CC: drepper.fsp at gmail dot com Target Milestone: --- recent gcc change exposed an invalid -1 << n in timezone/private.h if time_t is signed: /* The minimum and maximum finite time values. */ static time_t const time_t_min = (TYPE_SIGNED(time_t) ? (time_t) -1 << (CHAR_BIT * sizeof (time_t) - 1) : 0); static time_t const time_t_max = (TYPE_SIGNED(time_t) ? - (~ 0 < 0) - ((time_t) -1 << (CHAR_BIT * sizeof (time_t) - 1)) : -1); the gcc warning may get silenced as it caused other problems: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66066 but the UB should be fixed. There is no simple solution: the above code seems to want to support non-two's-complement signed int representations too. I think a solution based on (uintmax_t)-1 >> n can work for time_t_max with reasonable assumptions, otherwise arch specific soulution can be used. -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2015-05-11 17:05 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-11 17:05 nszabolcs at gmail dot com [this message] 2015-05-11 17:41 ` [Bug libc/18396] " joseph at codesourcery dot com 2015-08-27 22:27 ` [Bug time/18396] " jsm28 at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-18396-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).