[Bug math/18397] New: mips16 __fpu_control handling broken for static linking

[Bug math/18397] New: mips16 __fpu_control handling broken for static linking

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18397

            Bug ID: 18397
           Summary: mips16 __fpu_control handling broken for static
                    linking
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
  Target Milestone: ---
              Host: mips*-*-*

Programs are supposed to be able to define the __fpu_control variable,
overriding the library's version to cause the floating-point control word to be
set to the chosen value at startup.

This is broken for mips16 for static linking because the library's
__fpu_control variable is in the same object file as the helper functions used
by fpu_control.h for mips16, so test-fpucw-ieee-static fails to link with
multiple definitions of __fpu_control.

Testing a patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/18397] mips16 __fpu_control handling broken for static linking

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18397

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  34cb304e5a6df706e186d504b69af974bfc15a2f (commit)
      from  b13b96ca05a132a12dc5f3712b99e626670716bf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=34cb304e5a6df706e186d504b69af974bfc15a2f

commit 34cb304e5a6df706e186d504b69af974bfc15a2f
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon May 11 22:58:10 2015 +0000

    Fix mips16 __fpu_control static linking (bug 18397).

    Programs are supposed to be able to define the __fpu_control variable,
    overriding the library's version to cause the floating-point control
    word to be set to the chosen value at startup.

    This is broken for mips16 for static linking because the library's
    __fpu_control variable is in the same object file as the helper
    functions used by fpu_control.h for mips16, so test-fpucw-ieee-static
    fails to link with multiple definitions of __fpu_control.

    This patch fixes this by putting the helpers in a separate file rather
    than overriding fpu_control.c.  Tested for mips16 that this fixes the
    link failure and the ABI tests still pass.

        [BZ #18397]
        * sysdeps/mips/mips32/fpu/fpu_control.c: Move to ....
        * sysdeps/mips/mips32/fpu/fpucw-helpers.c: ... here.  Include
        <fpu_control.h> instead of <math/fpu_control.c>.
        * sysdeps/mips/mips32/fpu/Makefile: New file.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |    8 ++++++++
 NEWS                                               |    2 +-
 .../{aarch64/soft-fp => mips/mips32/fpu}/Makefile  |    2 +-
 .../mips32/fpu/{fpu_control.c => fpucw-helpers.c}  |    2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)
 copy sysdeps/{aarch64/soft-fp => mips/mips32/fpu}/Makefile (52%)
 rename sysdeps/mips/mips32/fpu/{fpu_control.c => fpucw-helpers.c} (97%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/18397] mips16 __fpu_control handling broken for static linking

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18397

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.