public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "ma.jiang at zte dot com.cn" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug malloc/18505] New: sysmalloc delete newly created heap Date: Tue, 09 Jun 2015 07:26:00 -0000 [thread overview] Message-ID: <bug-18505-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=18505 Bug ID: 18505 Summary: sysmalloc delete newly created heap Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: malloc Assignee: unassigned at sourceware dot org Reporter: ma.jiang at zte dot com.cn Target Milestone: --- Hi all, There is a bug in sysmalloc, which will slow down memory allocation. In the "if ((heap = new_heap (nb + (MINSIZE + sizeof (*heap)), mp_.top_pad)))" branch. " top (av) = chunk_at_offset (heap, sizeof (*heap));" set the av->top to the newly created heap. Then "if (old_size >= MINSIZE)" we will call " _int_free (av, old_top, 1);". _int_free will call heap_trim at the end. In heap_trim, becasue "top_chunk == chunk_at_offset(heap, sizeof(*heap))" is true(we just set av->top to the newly created heap...), the newly created heap was deleted and topchunk was moved to oldtop. Although we can probably get the memory from main_arena later(__libc_malloc will retry if failed), this bug slow down allocation, and should be fixed. In my opinion, _int_free should be called after the final allocation have been done.Just add a new bool variable need_free_oldtop, replace all call to _int_free with need_free_oldtop=true, add a line "if (need_free_oldtop) _int_free(av, old_top, 1);" just before "return chunk2mem (p);". This should be enough for the bug. -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2015-06-09 7:26 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-09 7:26 ma.jiang at zte dot com.cn [this message] 2015-06-10 13:26 ` [Bug malloc/18505] " fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-18505-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).