From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-28471-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 109856 invoked by alias); 9 Jun 2015 07:26:53 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Received: (qmail 109783 invoked by uid 48); 9 Jun 2015 07:26:49 -0000
From: "ma.jiang at zte dot com.cn" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug malloc/18505] New: sysmalloc  delete newly created heap
Date: Tue, 09 Jun 2015 07:26:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: malloc
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ma.jiang at zte dot com.cn
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-18505-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg00082.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=18505

            Bug ID: 18505
           Summary: sysmalloc  delete newly created heap
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: malloc
          Assignee: unassigned at sourceware dot org
          Reporter: ma.jiang at zte dot com.cn
  Target Milestone: ---

Hi all,
   There is a bug in sysmalloc, which will slow down memory allocation.
   In the "if ((heap = new_heap (nb + (MINSIZE + sizeof (*heap)),
mp_.top_pad)))" branch. " top (av) = chunk_at_offset (heap, sizeof (*heap));"
set the av->top to the newly created heap. Then "if (old_size >= MINSIZE)" we
will call " _int_free (av, old_top, 1);". _int_free will call heap_trim at the
end. In heap_trim, becasue "top_chunk == chunk_at_offset(heap, sizeof(*heap))"
is true(we just set av->top to the newly created heap...), the newly created
heap was deleted and topchunk was moved to oldtop.
   Although we can probably get the memory from main_arena later(__libc_malloc
will retry if failed), this bug slow down allocation, and should be fixed.
   In my opinion, _int_free should be called after the final allocation have
been done.Just add a new bool variable need_free_oldtop, replace all call to
_int_free with need_free_oldtop=true, add a line "if (need_free_oldtop)
_int_free(av, old_top, 1);" just before "return chunk2mem (p);". This should be
enough for the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.