[Bug build/18512] New: make install failure with overridden prefix

[Bug build/18512] New: make install failure with overridden prefix

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18512

            Bug ID: 18512
           Summary: make install failure with overridden prefix
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: msebor at redhat dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

Attempting to install glibc configured with --prefix=/usr into a non-standard
directory specified by the prefix make variable fails with the error below:

$ /src/glibc-trunk/configure --prefix=/usr
...
$ nice make install prefix=/build/glibc-trunk-install-prefix-override-usr
make[3]: Leaving directory `/src/glibc-trunk/elf'
/usr/bin/install -c /build/glibc-trunk/elf/ld.so /lib64/ld-2.21.90.so.new
/usr/bin/install: cannot create regular file '/lib64/ld-2.21.90.so.new':
Permission denied
make[2]: *** [/lib64/ld-2.21.90.so] Error 1
make[2]: Leaving directory `/src/glibc-trunk/elf'
make[1]: *** [elf/ldso_install] Error 2
make[1]: Leaving directory `/src/glibc-trunk'
make: *** [install] Error 2

However, with glibc configured with a different prefix the same installation
succeeds.

(Setting the DESTDIR variable works as one would expect.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18512] make install failure with overridden prefix

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18512

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
Placing into waiting since this is something that is easily worked around by
reconfiguring, rebuilding, and then installing, or installing with DESTDIR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18512] make install failure with overridden prefix

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18512

--- Comment #3 from Martin Sebor <msebor at redhat dot com> ---
In section 7.2.5 Variables for Installation Directories, the GNU Coding
Standard describes the prefix fix variable as the mechanism expected to be used
to override the standard installation directory.  If GLIBC doesn't supported
this use case (which I would find understandable), I propose mentioning it in
GLIBC documentation (i.e., in the INSTALL file and online).  In fact, I already
have a patch for INSTALL to that effect but have been waiting for feedback on
this issue before submitting it.  With the patch accepted I think the issue can
be resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18512] make install failure with overridden prefix

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18512

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Martin Sebor from comment #3)
> In section 7.2.5 Variables for Installation Directories, the GNU Coding
> Standard describes the prefix fix variable as the mechanism expected to be
> used to override the standard installation directory.  If GLIBC doesn't
> supported this use case (which I would find understandable), I propose
> mentioning it in GLIBC documentation (i.e., in the INSTALL file and online).
> In fact, I already have a patch for INSTALL to that effect but have been
> waiting for feedback on this issue before submitting it.  With the patch
> accepted I think the issue can be resolved.

You are correct, it is indeed in the GNU Coding Standards, and while we strive
to adhere to the standard where possible, in this particular case we don't have
the infrastructure to support installing to an alternate prefix without a
recompilation. To do so would require a data-driven approach to determe the
prefix at runtime, and while such an approach would actually be interesting for
testing, nobody has implemented it yet (chroot, containers, or vm's are used
instead).

I would support a patch to INSTALL to correct this. Though I would like it even
more if `make install prefix=/foo` failed if /foo didn't match the configure's
prefix argument.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18512] make install failure with overridden prefix

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18512

Martin Sebor <msebor at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at sourceware dot org   |msebor at redhat dot com
   Target Milestone|---                         |2.22

--- Comment #5 from Martin Sebor <msebor at redhat dot com> ---
Fixed by having make install fail early and with a descriptive error message by
commit a82a3db95077c8343b988a6f1b03adea3d40f6d4:

Author: Martin Sebor <msebor@redhat.com>
Date:   Fri Jun 12 13:15:57 2015 -0600

    Attempting to install glibc configured with --prefix=/usr into
    a non-standard directory specified by the prefix make variable
    fails with an error.  Since this is an unsupported use case,
    this change makes make install fail early and with a descriptive
    error message when either the prefix or the exec_prefix make
    variable is overridden on the command line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.