[Bug libc/18519] New: aio_* pread namespace

[Bug libc/18519] New: aio_* pread namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18519

            Bug ID: 18519
           Summary: aio_* pread namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

aio_* bring in references to pread, which isn't in all the standards containing
aio_*.

[initial] aio_fsync -> [librt.a(aio_fsync.o)] __aio_enqueue_request ->
[librt.a(aio_misc.o)] pread

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18519] aio_* pread namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18519

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9714012ca015f1f6763f66bd74d6f3f9e1512b36 (commit)
      from  498c1f6a7c7f7b634d02e740f15789cf68820a54 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9714012ca015f1f6763f66bd74d6f3f9e1512b36

commit 9714012ca015f1f6763f66bd74d6f3f9e1512b36
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 12 17:34:11 2015 +0000

    Fix aio_* pread namespace (bug 18519).

    aio_* bring in references to pread, which isn't in all the standards
    containing aio_* (as a reference from one library to another, this is
    a bug for dynamic as well as static linking).  This patch fixes this
    by using __libc_pread instead, exporting that function from libc at
    symbol version GLIBC_PRIVATE; the code, with conditionals that may
    call either __pread64 or __libc_pread, becomes exactly analogous to
    that elsewhere in the same file that may call either __pwrite64 or
    __libc_pwrite.

    Tested for x86_64 and x86 (testsuite, and comparison of disassembly of
    installed shared libraries).  libc changes because of the PLT entry
    for the newly exported __libc_pread; librt changes because of
    assertion line numbers and PLT rearrangement; other stripped installed
    shared libraries do not change.

        [BZ #18519]
        * posix/Versions (libc): Export __libc_pread at version
        GLIBC_PRIVATE.
        * sysdeps/pthread/aio_misc.c (handle_fildes_io): Call __libc_pread
        instead of pread.
        * conform/Makefile (test-xfail-POSIX/aio.h/linknamespace): Remove
        variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                  |    8 ++++++++
 NEWS                       |    2 +-
 conform/Makefile           |    1 -
 posix/Versions             |    2 +-
 sysdeps/pthread/aio_misc.c |    9 +++++----
 5 files changed, 15 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18519] aio_* pread namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18519

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.