public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18519] aio_* pread namespace
Date: Fri, 12 Jun 2015 17:35:00 -0000	[thread overview]
Message-ID: <bug-18519-131-zhj29VJ2uQ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18519-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=18519

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9714012ca015f1f6763f66bd74d6f3f9e1512b36 (commit)
      from  498c1f6a7c7f7b634d02e740f15789cf68820a54 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9714012ca015f1f6763f66bd74d6f3f9e1512b36

commit 9714012ca015f1f6763f66bd74d6f3f9e1512b36
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 12 17:34:11 2015 +0000

    Fix aio_* pread namespace (bug 18519).

    aio_* bring in references to pread, which isn't in all the standards
    containing aio_* (as a reference from one library to another, this is
    a bug for dynamic as well as static linking).  This patch fixes this
    by using __libc_pread instead, exporting that function from libc at
    symbol version GLIBC_PRIVATE; the code, with conditionals that may
    call either __pread64 or __libc_pread, becomes exactly analogous to
    that elsewhere in the same file that may call either __pwrite64 or
    __libc_pwrite.

    Tested for x86_64 and x86 (testsuite, and comparison of disassembly of
    installed shared libraries).  libc changes because of the PLT entry
    for the newly exported __libc_pread; librt changes because of
    assertion line numbers and PLT rearrangement; other stripped installed
    shared libraries do not change.

        [BZ #18519]
        * posix/Versions (libc): Export __libc_pread at version
        GLIBC_PRIVATE.
        * sysdeps/pthread/aio_misc.c (handle_fildes_io): Call __libc_pread
        instead of pread.
        * conform/Makefile (test-xfail-POSIX/aio.h/linknamespace): Remove
        variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                  |    8 ++++++++
 NEWS                       |    2 +-
 conform/Makefile           |    1 -
 posix/Versions             |    2 +-
 sysdeps/pthread/aio_misc.c |    9 +++++----
 5 files changed, 15 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


      parent reply	other threads:[~2015-06-12 17:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 14:57 [Bug libc/18519] New: " jsm28 at gcc dot gnu.org
2015-06-12 17:35 ` [Bug libc/18519] " jsm28 at gcc dot gnu.org
2015-06-12 17:35 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18519-131-zhj29VJ2uQ@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).