From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16429 invoked by alias); 12 Jun 2015 20:03:30 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 16037 invoked by uid 55); 12 Jun 2015 20:03:23 -0000 From: "cvs-commit at gcc dot gnu.org" To: glibc-bugs@sourceware.org Subject: [Bug libc/18527] getlogin_r namespace Date: Fri, 12 Jun 2015 20:03:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.21 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-06/txt/msg00134.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=18527 --- Comment #1 from cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via 5371d99e8766f25864ddf20fb0866e57fc0b7991 (commit) from a82a3db95077c8343b988a6f1b03adea3d40f6d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5371d99e8766f25864ddf20fb0866e57fc0b7991 commit 5371d99e8766f25864ddf20fb0866e57fc0b7991 Author: Joseph Myers Date: Fri Jun 12 20:02:30 2015 +0000 Fix getlogin_r namespace (bug 18527). Various functions in XPG4 bring in references to getlogin_r, which is not in XPG4; this is also a bug for some older POSIX versions which aren't yet covered by the linknamespace tests. This patch fixes this by making getlogin_r into a weak alias for __getlogin_r and using __getlogin_r as needed. Tested for x86_64 and x86 (testsuite, and that disassembly of installed stripped shared libraries is unchanged by the patch). [BZ #18527] * login/getlogin_r.c (getlogin_r): Rename to __getlogin_r and define as weak alias of __getlogin_r. Use libc_hidden_weak. * sysdeps/mach/hurd/getlogin_r.c (getlogin_r): Likewise. * sysdeps/unix/getlogin_r.c (getlogin_r): Likewise. * sysdeps/unix/sysv/linux/getlogin_r.c (getlogin_r): Likewise. * include/unistd.h (__getlogin_r): Declare. Use libc_hidden_proto. * posix/glob.c (glob): Call __getlogin_r instead of getlogin_r. * conform/Makefile (test-xfail-XPG3/glob.h/linknamespace): Remove variable. (test-xfail-XPG3/wordexp.h/linknamespace): Likewise. (test-xfail-XPG4/glob.h/linknamespace): Likewise. (test-xfail-XPG4/wordexp.h/linknamespace): Likewise. ----------------------------------------------------------------------- Summary of changes: ChangeLog | 17 +++++++++++++++++ NEWS | 2 +- conform/Makefile | 4 ---- include/unistd.h | 2 ++ login/getlogin_r.c | 6 ++++-- posix/glob.c | 2 +- sysdeps/mach/hurd/getlogin_r.c | 6 ++++-- sysdeps/unix/getlogin_r.c | 6 ++++-- sysdeps/unix/sysv/linux/getlogin_r.c | 10 ++++++---- 9 files changed, 39 insertions(+), 16 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.