[Bug libc/18527] New: getlogin_r namespace

[Bug libc/18527] New: getlogin_r namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18527

            Bug ID: 18527
           Summary: getlogin_r namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

Various functions in XPG4 bring in references to getlogin_r, which is not in
XPG4.

[initial] glob -> [libc.a(glob.o)] getlogin_r
[initial] getlogin -> [libc.a(getlogin.o)] __getlogin_r_loginuid ->
[libc.a(getlogin_r.o)] getlogin_r
[initial] wordexp -> [libc.a(wordexp.o)] glob -> [libc.a(glob.o)] getlogin_r

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18527] getlogin_r namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18527

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5371d99e8766f25864ddf20fb0866e57fc0b7991 (commit)
      from  a82a3db95077c8343b988a6f1b03adea3d40f6d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5371d99e8766f25864ddf20fb0866e57fc0b7991

commit 5371d99e8766f25864ddf20fb0866e57fc0b7991
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 12 20:02:30 2015 +0000

    Fix getlogin_r namespace (bug 18527).

    Various functions in XPG4 bring in references to getlogin_r, which is
    not in XPG4; this is also a bug for some older POSIX versions which
    aren't yet covered by the linknamespace tests.  This patch fixes this
    by making getlogin_r into a weak alias for __getlogin_r and using
    __getlogin_r as needed.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed stripped shared libraries is unchanged by the patch).

        [BZ #18527]
        * login/getlogin_r.c (getlogin_r): Rename to __getlogin_r and
        define as weak alias of __getlogin_r.  Use libc_hidden_weak.
        * sysdeps/mach/hurd/getlogin_r.c (getlogin_r): Likewise.
        * sysdeps/unix/getlogin_r.c (getlogin_r): Likewise.
        * sysdeps/unix/sysv/linux/getlogin_r.c (getlogin_r): Likewise.
        * include/unistd.h (__getlogin_r): Declare.  Use
        libc_hidden_proto.
        * posix/glob.c (glob): Call __getlogin_r instead of getlogin_r.
        * conform/Makefile (test-xfail-XPG3/glob.h/linknamespace): Remove
        variable.
        (test-xfail-XPG3/wordexp.h/linknamespace): Likewise.
        (test-xfail-XPG4/glob.h/linknamespace): Likewise.
        (test-xfail-XPG4/wordexp.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                            |   17 +++++++++++++++++
 NEWS                                 |    2 +-
 conform/Makefile                     |    4 ----
 include/unistd.h                     |    2 ++
 login/getlogin_r.c                   |    6 ++++--
 posix/glob.c                         |    2 +-
 sysdeps/mach/hurd/getlogin_r.c       |    6 ++++--
 sysdeps/unix/getlogin_r.c            |    6 ++++--
 sysdeps/unix/sysv/linux/getlogin_r.c |   10 ++++++----
 9 files changed, 39 insertions(+), 16 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18527] getlogin_r namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18527

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.