[Bug libc/18530] New: syslog fputs_unlocked namespace

[Bug libc/18530] New: syslog fputs_unlocked namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18530

            Bug ID: 18530
           Summary: syslog fputs_unlocked namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

syslog (XSI POSIX) brings in references to fputs_unlocked (not POSIX).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18530] syslog fputs_unlocked namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18530

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  3164bf09f529754216eebfa66a5c32ce84eaec25 (commit)
      from  8737be806407be51f046b358d8824c4c968912de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3164bf09f529754216eebfa66a5c32ce84eaec25

commit 3164bf09f529754216eebfa66a5c32ce84eaec25
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 12 22:36:38 2015 +0000

    Fix syslog fputs_unlocked namespace (bug 18530).

    syslog (XSI POSIX) brings in references to fputs_unlocked (not
    POSIX).  This patch fixes this by making fputs_unlocked into a weak
    alias for __fputs_unlocked and using __fputs_unlocked as needed.  (No
    linknamespace test XFAILs are removed because there are other failures
    from syslog as well.)

    Tested for x86_64 and x86 (testsuite, and comparison of disassembly of
    installed stripped shared libraries).  Disassembly of installed
    stripped shared libraries is unchanged on x86_64; on x86, I see some
    small changes to instruction ordering and register choice, with no
    apparent reason for such changes to be related to this patch, but they
    also seem completely harmless with no change to code size.

        [BZ #18530]
        * libio/iofputs.c [!_IO_MTSAFE_IO] (__fputs_unlocked): Define as
        strong alias of _IO_fputs.  Use libc_hidden_def.
        * libio/iofputs_u.c (fputs_unlocked): Rename to __fputs_unlocked
        and define as weak alias of __fputs_unlocked.  Use
        libc_hidden_weak.
        * include/stdio.h (__fputs_unlocked): Declare.  Use
        libc_hidden_proto.
        * misc/syslog.c (__vsyslog_chk): Call __fputs_unlocked instead of
        fputs_unlocked.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog         |   11 +++++++++++
 NEWS              |    2 +-
 include/stdio.h   |    2 ++
 libio/iofputs.c   |    2 ++
 libio/iofputs_u.c |    6 ++++--
 misc/syslog.c     |    2 +-
 6 files changed, 21 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18530] syslog fputs_unlocked namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18530

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.