[Bug network/18532] New: gethostbyaddr in6addr_any, in6addr_loopback namespace

[Bug network/18532] New: gethostbyaddr in6addr_any, in6addr_loopback namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18532

            Bug ID: 18532
           Summary: gethostbyaddr in6addr_any, in6addr_loopback namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: network
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
  Target Milestone: ---

gethostbyaddr brings in references to in6addr_any and thereby in6addr_loopback,
which aren't in all the standards containing gethostbyaddr (gethostbyaddr is in
XPG4 and UNIX98, in6addr_any and in6addr_loopback are new in POSIX.1:2001).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18532] gethostbyaddr in6addr_any, in6addr_loopback namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18532

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  bf1435783d5031e54f2f74ba3028db3c225a9da8 (commit)
      from  3164bf09f529754216eebfa66a5c32ce84eaec25 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bf1435783d5031e54f2f74ba3028db3c225a9da8

commit bf1435783d5031e54f2f74ba3028db3c225a9da8
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Sun Jun 14 14:32:07 2015 +0000

    Fix linknamespace expectations for in6addr_any, in6addr_loopback.

    Some linknamespace test failures turned out to be because the
    variables in6addr_any and in6addr_loopback weren't listed in the lists
    of extra reserved symbols for the relevant standards (only functions
    are handled automatically through -aux-info, data symbols need listing
    manually in list-header-symbols.pl).  This patch duly adds those
    symbols to those lists (there are still failures for older standards
    because of references to those symbols being brought in for standards
    that didn't reserve them: bug 18532, to be fixed separately).

    Tested for x86_64.

        * conform/list-header-symbols.pl (%extra_syms): Add in6addr_any
        and in6addr_loopback for XOPEN2K, XOPEN2K8 and POSIX2008.
        * conform/Makefile (test-xfail-XOPEN2K/netdb.h/linknamespace):
        Remove variable.
        (test-xfail-POSIX2008/netdb.h/linknamespace): Likewise.
        (test-xfail-XOPEN2K8/netdb.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                      |    9 +++++++++
 conform/Makefile               |    3 ---
 conform/list-header-symbols.pl |    7 ++++---
 3 files changed, 13 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18532] gethostbyaddr in6addr_any, in6addr_loopback namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18532

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  17c199ee92e4ca8a34a47c42924608a25a444eb2 (commit)
      from  c10b9b13f7471b08273effc8cd7e51b119df9348 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=17c199ee92e4ca8a34a47c42924608a25a444eb2

commit 17c199ee92e4ca8a34a47c42924608a25a444eb2
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Jun 17 20:08:22 2015 +0000

    Fix gethostbyaddr in6addr_any, in6addr_loopback namespace (bug 18532).

    gethostbyaddr brings in references to in6addr_any and thereby
    in6addr_loopback, which aren't in all the standards containing
    gethostbyaddr (gethostbyaddr is in XPG4 and UNIX98, in6addr_any and
    in6addr_loopback are new in POSIX.1:2001).  This patch fixes this by
    making those symbols into weak aliases (safe in this case, unlike for
    most data symbols, because these data symbols are const).

    Tested for x86_64 and x86 (testsuite, and comparison of disassembly of
    installed stripped shared libraries).  Disassembly is unchanged for
    x86_64; for x86, I see some changes of stack offsets, but no other
    code generation changes or code size differences.

        [BZ #18532]
        * inet/in6_addr.c (in6addr_any): Rename to __in6addr_any and
        define as weak alias of __in6addr_any.  Use libc_hidden_data_weak.
        (in6addr_loopback): Rename to __in6addr_loopback and define as
        weak alias of __in6addr_loopback.  Use libc_hidden_data_weak.
        * include/netinet/in.h (__in6addr_loopback): Declare.  Use
        libc_hidden_proto.
        (__in6addr_any): Likewise.
        * inet/gethstbyad_r.c (PREPROCESS): Use __in6addr_any instead of
        in6addr_any.
        * conform/Makefile (test-xfail-XPG4/netdb.h/linknamespace): Remove
        variable.
        (test-xfail-UNIX98/netdb.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            |   16 ++++++++++++++++
 NEWS                 |    2 +-
 conform/Makefile     |    2 --
 include/netinet/in.h |    4 ++++
 inet/gethstbyad_r.c  |    2 +-
 inet/in6_addr.c      |   12 ++++++++----
 6 files changed, 30 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18532] gethostbyaddr in6addr_any, in6addr_loopback namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18532

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.