[Bug nptl/18536] New: sem_* tdelete, tfind, tsearch, twalk namespace

[Bug nptl/18536] New: sem_* tdelete, tfind, tsearch, twalk namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18536

            Bug ID: 18536
           Summary: sem_* tdelete, tfind, tsearch, twalk namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

The sem_* functions bring in references to tdelete, tfind, tsearch and twalk. 
But the t* functions are XSI-shaded, while sem_* aren't.

[initial] sem_close -> [libpthread.a(sem_close.o)] tdelete
[initial] sem_open -> [libpthread.a(sem_open.o)] tfind
[initial] sem_open -> [libpthread.a(sem_open.o)] tsearch
[initial] sem_close -> [libpthread.a(sem_close.o)] twalk

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/18536] sem_* tdelete, tfind, tsearch, twalk namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18536

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d051b143f73189311faf9cd311cc53c6f6a145db (commit)
      from  be7dc2b77e368daad6f81e272fc41f1b86166240 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d051b143f73189311faf9cd311cc53c6f6a145db

commit d051b143f73189311faf9cd311cc53c6f6a145db
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Jun 17 20:11:58 2015 +0000

    Fix sem_* tdelete, tfind, tsearch, twalk namespace (bug 18536).

    The sem_* functions bring in references to tdelete, tfind, tsearch and
    twalk.  But the t* functions are XSI-shaded, while sem_* aren't.  This
    patch fixes this by using __t* instead, exporting those functions from
    libc at version GLIBC_PRIVATE (since sem_* are in libpthread) and
    using libc_hidden_* for the benefit of calls within libc.

    Tested for x86_64 and x86 (testsuite, and comparison of disassembly of
    installed stripped shared libraries).  libpthread gets changes from
    PLT reordering; addresses in libc change because of PLT / dynamic
    symbol table changes.

        [BZ #18536]
        * misc/tsearch.c (__tsearch): Use libc_hidden_def.
        (__tfind): Likewise.
        (__tdelete): Likewise.
        (__twalk): Likewise.
        * misc/Versions (libc): Add __tdelete, __tfind, __tsearch and
        __twalk to GLIBC_PRIVATE.
        * include/search.h (__tsearch): Use libc_hidden_proto.
        (__tfind): Likewise.
        (__tdelete): Likewise.
        (__twalk): Likewise.
        * nptl/sem_close.c (sem_close): Call __twalk instead of twalk.
        Call __tdelete instead of tdelete.
        * nptl/sem_open.c (check_add_mapping): Call __tfind instead of
        tfind.  Call __tsearch instead of tsearch.
        * sysdeps/sparc/sparc32/sem_open.c (check_add_mapping): Likewise.
        * conform/Makefile (test-xfail-POSIX/semaphore.h/linknamespace):
        Remove variable.
        (test-xfail-POSIX2008/semaphore.h/linknamespace): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                        |   20 ++++++++++++++++++++
 NEWS                             |    2 +-
 conform/Makefile                 |    2 --
 include/search.h                 |    4 ++++
 misc/Versions                    |    1 +
 misc/tsearch.c                   |    4 ++++
 nptl/sem_close.c                 |    4 ++--
 nptl/sem_open.c                  |    5 +++--
 sysdeps/sparc/sparc32/sem_open.c |    5 +++--
 9 files changed, 38 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nptl/18536] sem_* tdelete, tfind, tsearch, twalk namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18536

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.