[Bug libc/18547] New: ttyslot namespace

[Bug libc/18547] New: ttyslot namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18547

            Bug ID: 18547
           Summary: ttyslot namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

ttyslot (XPG4) calls the non-XPG4 functions endttyent, getttyent and setttyent,
which in turn bring in references to fgets_unlocked and getttynam.

[initial] ttyslot -> [libc.a(ttyslot.o)] endttyent
[initial] ttyslot -> [libc.a(ttyslot.o)] endttyent -> [libc.a(getttyent.o)]
fgets_unlocked
[initial] ttyslot -> [libc.a(ttyslot.o)] getttyent
[initial] ttyslot -> [libc.a(ttyslot.o)] endttyent -> [libc.a(getttyent.o)]
getttynam
[initial] ttyslot -> [libc.a(ttyslot.o)] setttyent

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18547] ttyslot namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18547

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  abccad04b4172d552dbdae948c0e567ba266ad76 (commit)
      from  0595c98494c25f8eaa1a3298e8fa032ad5e4405e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=abccad04b4172d552dbdae948c0e567ba266ad76

commit abccad04b4172d552dbdae948c0e567ba266ad76
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Jun 17 20:21:19 2015 +0000

    Fix ttyslot namespace (bug 18547).

    ttyslot (XPG4) calls the non-XPG4 functions endttyent, getttyent and
    setttyent, which in turn bring in references to fgets_unlocked and
    getttynam.  This patch fixes this by making these functions into weak
    aliases and calling the __* names as needed.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed stripped shared libraries is unchanged by the patch).

        [BZ #18547]
        * misc/getttyent.c (getttynam): Rename to __getttynam and define
        as weak alias of __getttynam.  Use prototype function definition.
        Call __setttyent, __getttyent and __endttyent instead of
        setttyent, getttyent and endttyent.
        (getttyent): Rename to __getttyent and define as weak alias of
        __getttyent.  Call __setttyent instead of setttyent.  Call
        __fgets_unlocked instead of fgets_unlocked.
        (setttyent): Rename to __setttyent and define as weak alias of
        __setttyent.
        (endttyent): Rename to __endttyent and define as weak alias of
        __endttyent.
        * include/ttyent.h (__getttyent): Declare.  Use libc_hidden_proto.
        (__setttyent): Likewise.
        (__endttyent): Likewise.
        (getttyent): Don't use libc_hidden_proto.
        (setttyent): Likewise.
        (endttyent): Likewise.
        * misc/ttyslot.c (ttyslot): Call __setttyent, __getttyent and
        __endttyent instead of setttyent, getttyent and endttyent.
        * conform/Makefile (test-xfail-XPG4/unistd.h/linknamespace):
        Remove variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   23 +++++++++++++++++++++++
 NEWS             |    2 +-
 conform/Makefile |    1 -
 include/ttyent.h |    9 ++++++---
 misc/getttyent.c |   29 ++++++++++++++++-------------
 misc/ttyslot.c   |    8 ++++----
 6 files changed, 50 insertions(+), 22 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18547] ttyslot namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18547

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.