[Bug libc/18553] New: nice getpriority, setpriority namespace

[Bug libc/18553] New: nice getpriority, setpriority namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18553

            Bug ID: 18553
           Summary: nice getpriority, setpriority namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

nice (XPG3) calls getpriority and setpriority (in XPG4 but not XPG3, i.e.
UX-shaded in XPG4).

[initial] nice -> [libc.a(nice.o)] getpriority
[initial] nice -> [libc.a(nice.o)] setpriority

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18553] nice getpriority, setpriority namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18553

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c36213513490412941512daccf447513e442651b (commit)
      from  abccad04b4172d552dbdae948c0e567ba266ad76 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c36213513490412941512daccf447513e442651b

commit c36213513490412941512daccf447513e442651b
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Jun 17 20:22:39 2015 +0000

    Fix nice getpriority, setpriority namespace (bug 18553).

    nice (XPG3) calls getpriority and setpriority (in XPG4 but not XPG3,
    i.e. UX-shaded in XPG4).  This patch fixes this by making those
    functions into weak aliases of __* functions and calling the __*
    versions as needed.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed shared libraries is unchanged by this patch).

    This completes cleaning up the unsorted linknamespace test XFAILs.

        [BZ #18553]
        * resource/getpriority.c (getpriority): Rename to __getpriority
        and define as weak alias of __getpriority.
        * resource/setpriority.c (setpriority): Rename to __setpriority
        and define as weak alias of __setpriority.
        * sysdeps/mach/hurd/getpriority.c (getpriority): Rename to
        __getpriority and define as weak alias of __getpriority.
        * sysdeps/mach/hurd/setpriority.c (setpriority): Rename to
        __setpriority and define as weak alias of __setpriority.
        * sysdeps/unix/syscalls.list (getpriority): Use __getpriority as
        strong name.
        (setpriority): Use __setpriority as strong name.
        * sysdeps/unix/sysv/linux/getpriority.c (getpriority): Rename to
        __getpriority and define as weak alias of __getpriority.
        * include/sys/resource.h (__getpriority): Declare.  Use
        libc_hidden_proto.
        (__setpriority): Likewise.
        (getpriority): Don't use libc_hidden_proto.
        (setpriority): Likewise.
        * sysdeps/posix/nice.c (nice): Call __getpriority instead of
        getpriority.  Call __setpriority instead of setpriority.
        * conform/Makefile (test-xfail-XPG3/unistd.h/linknamespace):
        Remove variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |   24 ++++++++++++++++++++++++
 NEWS                                  |    3 ++-
 conform/Makefile                      |    3 ---
 include/sys/resource.h                |   10 ++++++++--
 resource/getpriority.c                |    5 +++--
 resource/setpriority.c                |    5 +++--
 sysdeps/mach/hurd/getpriority.c       |    5 +++--
 sysdeps/mach/hurd/setpriority.c       |    5 +++--
 sysdeps/posix/nice.c                  |    6 +++---
 sysdeps/unix/syscalls.list            |    4 ++--
 sysdeps/unix/sysv/linux/getpriority.c |    5 +++--
 11 files changed, 54 insertions(+), 21 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18553] nice getpriority, setpriority namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18553

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.