[Bug network/18557] New: ruserok has bad scalability with large ~/.rhosts file.

[Bug network/18557] New: ruserok has bad scalability with large ~/.rhosts file.

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18557

            Bug ID: 18557
           Summary: ruserok has bad scalability with large ~/.rhosts file.
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: network
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
  Target Milestone: ---

With a very large ~/.rhosts file the number of DNS queries per entry causes
scalability issues. It can take minutes to login if you have a very very large
~/.rhosts file.

As an optimization the ruserok and related API functions could short-circuit
check if the user matched and move on to the next line if possible. This goes a
long way to helping certain use cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18557] ruserok has bad scalability with large ~/.rhosts file.

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18557

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8b59c73386ddb64331ee03c29925a18dae547733 (commit)
      from  02d5e5d94a78d32e940dfb3b58ab7f06c31b0f76 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8b59c73386ddb64331ee03c29925a18dae547733

commit 8b59c73386ddb64331ee03c29925a18dae547733
Author: Carlos O'Donell <carlos@systemhalted.org>
Date:   Wed Jul 8 02:42:11 2015 -0400

    Fix ruserok scalability with large ~/.rhosts file.

    Fixes bug 18557.

    The ruserok API does hosts checks first while it walks the
    user's ~/.rhosts file. This results in lots of DNS queries
    that could have been skipped if we short-circuit test the
    user portion first to see if would have had a failed match.

    This supports configurations where rlogin is used on internal
    secure networks with large numbers of users and machines.

    The Red Hat QE team did extensive testing on various rlogin
    combinations to validate this change, and in fact we found
    a defect in the first version which is fixed in this version.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog   |    6 ++++++
 NEWS        |   36 ++++++++++++++++++------------------
 inet/rcmd.c |   50 +++++++++++++++++++++++++++++++-------------------
 3 files changed, 55 insertions(+), 37 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18557] ruserok has bad scalability with large ~/.rhosts file.

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18557

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.22

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/18557] ruserok has bad scalability with large ~/.rhosts file.

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18557

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.