public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug locale/18589] sort-test.sh fails at random Date: Thu, 08 Oct 2015 20:42:00 -0000 [thread overview] Message-ID: <bug-18589-131-1PYVhzIc2g@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-18589-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=18589 --- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via 87701a58e291bd7ac3b407d10a829dac52c9c16e (commit) from fd91891a5091b5f54680180dc0c8e91827f63c70 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=87701a58e291bd7ac3b407d10a829dac52c9c16e commit 87701a58e291bd7ac3b407d10a829dac52c9c16e Author: Carlos O'Donell <carlos@systemhalted.org> Date: Thu Oct 8 16:34:53 2015 -0400 strcoll: Remove incorrect STRDIFF-based optimization (Bug 18589). The optimization introduced in commit f13c2a8dff2329c6692a80176262ceaaf8a6f74e, causes regressions in sorting for languages that have digraphs that change sort order, like cs_CZ which sorts ch between h and i. My analysis shows the fast-forwarding optimization in STRCOLL advances through a digraph while possibly stopping in the middle which results in a subsequent skipping of the digraph and incorrect sorting. The optimization is incorrect as implemented and because of that I'm removing it for 2.23, and I will also commit this fix for 2.22 where it was originally introduced. This patch reverts the optimization, introduces a new bug-strcoll2.c regression test that tests both cs_CZ.UTF-8 and da_DK.ISO-8859-1 and ensures they sort one digraph each correctly. The optimization can't be applied without regressing this test. Checked on x86_64, bug-strcoll2.c fails without this patch and passes after. This will also get a fix on 2.22 which has the same bug. ----------------------------------------------------------------------- Summary of changes: ChangeLog | 14 ++++++ NEWS | 14 +++--- locale/C-collate.c | 4 +- locale/categories.def | 1 - locale/langinfo.h | 1 - locale/localeinfo.h | 8 ---- locale/programs/ld-collate.c | 9 ---- string/bug-strcoll2.c | 93 ++++++++++++++++++++++++++++++++++++++++++ string/strcoll_l.c | 38 +----------------- wcsmbs/wcscoll_l.c | 1 - 10 files changed, 116 insertions(+), 67 deletions(-) create mode 100644 string/bug-strcoll2.c -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2015-10-08 20:42 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-24 10:04 [Bug localedata/18589] New: " hjl.tools at gmail dot com 2015-07-28 17:48 ` [Bug localedata/18589] " jsm28 at gcc dot gnu.org 2015-08-27 22:00 ` [Bug locale/18589] " jsm28 at gcc dot gnu.org 2015-09-07 15:36 ` egmont at gmail dot com 2015-09-08 8:33 ` egmont at gmail dot com 2015-09-08 8:40 ` egmont at gmail dot com 2015-10-08 17:18 ` egmont at gmail dot com 2015-10-08 17:27 ` carlos at redhat dot com 2015-10-08 17:27 ` carlos at redhat dot com 2015-10-08 17:41 ` egmont at gmail dot com 2015-10-08 17:43 ` hjl.tools at gmail dot com 2015-10-08 18:14 ` joseph at codesourcery dot com 2015-10-08 20:42 ` cvs-commit at gcc dot gnu.org [this message] 2015-10-08 21:03 ` cvs-commit at gcc dot gnu.org 2015-10-09 20:40 ` cvs-commit at gcc dot gnu.org 2015-10-10 0:43 ` cvs-commit at gcc dot gnu.org 2015-10-10 0:48 ` carlos at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-18589-131-1PYVhzIc2g@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).