public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18641] pwd.h: add __nonnull markings
Date: Fri, 24 Jul 2015 14:44:00 -0000 [thread overview]
Message-ID: <bug-18641-131-v4TKifOPzi@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18641-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18641
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fweimer at redhat dot com
Flags| |security-
--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Mike Frysinger from comment #0)
> per the thread:
> https://sourceware.org/ml/libc-alpha/2015-05/msg00867.html
>
> when you use many functions in pwd.h with NULL pointers, glibc will crash.
> POSIX doesn't require NULL to be supported, so we want to mark all the funcs
> as nonnull instead. this way user code is compiled with warnings and our
> API expectations are documented.
I couldn't find this discussed on the mailing list.
putpwent at least is documented as returning EINVAL for NULL arguments in its
manual page:
EINVAL Invalid (NULL) argument given.
And the code has checks for that. Future GCC versions may rewrite the NULL
check to an abort because of the nonnull attribute with just -O2 optimization.
I am not convinced this is what we want.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2015-07-24 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 7:16 [Bug libc/18641] New: " vapier at gentoo dot org
2015-07-08 7:22 ` [Bug libc/18641] " vapier at gentoo dot org
2015-07-08 7:22 ` cvs-commit at gcc dot gnu.org
2015-07-24 14:44 ` fweimer at redhat dot com [this message]
2015-07-28 3:41 ` vapier at gentoo dot org
2015-07-28 3:47 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-18641-131-v4TKifOPzi@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).