[Bug build/18969] New: multiple string test failures due to missing locale dependencies

[Bug build/18969] New: multiple string test failures due to missing locale dependencies

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18969

            Bug ID: 18969
           Summary: multiple string test failures due to missing locale
                    dependencies
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: minor
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: msebor at redhat dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

Created attachment 8611
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8611&action=edit
Proposed patch tested on powerpc64le.

After glibc has been built but before 'make check' has been invoked, running
'make check subdirs=string' causes four string tests to fail that otherwise
succeed.  The failures can also be reproduced by removing the contents of the
localedata directory and invoking make check as shown below.  The cause of the
failures is a missing dependency of the string makefile on the locales used by
string tests.

In addition, while three of the four tests produce output that makes the reason
for their failures clear by printing the names of the locales they couldn't
set, string/tst-strxfrm2 prints the less helpful "setlocale failed."

The attached patch fixes both problems by a) adding the missing dependency on
gen-locales.mk to string/Makefile and setting the LOCALES variable to the names
of the prerequisite locales, and b) printing the name of the failed locale in
tst-strxfrm2.

$ rm -rf localedata/* string/test-*.out; nice make subdirs=string -k check
...
FAIL: string/test-strcasecmp
FAIL: string/test-strncasecmp
FAIL: string/tst-strxfrm
FAIL: string/tst-strxfrm2
Summary of test results:
      4 FAIL
     55 PASS
make[1]: *** [tests] Error 1
make[1]: Target `check' not remade because of errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18969] multiple string test failures due to missing locale dependencies

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18969

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
Please send patches to libc-alpha.  I don't think the string directory is 
the only one depending on localedata tests having been run first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18969] multiple string test failures due to missing locale dependencies

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18969

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mike Frysinger <vapier at gentoo dot org> ---
pushed here:
https://sourceware.org/git/?p=glibc.git;a=commit;h=60cf80f09d029257caedc0c8abe7e3e09c64e6c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18969] multiple string test failures due to missing locale dependencies

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18969

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f881f6ff62bba53448c5d8997287ea2e628b3a65 (commit)
      from  c7b8939bf5646d1033375128f19261b401b9a0ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f881f6ff62bba53448c5d8997287ea2e628b3a65

commit f881f6ff62bba53448c5d8997287ea2e628b3a65
Author: Andreas Schwab <schwab@suse.de>
Date:   Mon Oct 12 12:24:41 2015 +0200

    Add dependencies on needed locales in each subdir tests (bug 18969)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog             |   59 +++++++++++++++++++++++++++++++++++++++++++++++++
 debug/Makefile        |    7 +++++
 iconvdata/Makefile    |    8 ++++++
 intl/Makefile         |   13 ++++++++++
 libio/Makefile        |   24 ++++++++++++++++++++
 libio/tst_wprintf2.c  |    2 +-
 posix/Makefile        |   30 +++++++++++++++++++++++++
 stdio-common/Makefile |   13 ++++++++++
 stdlib/Makefile       |   12 ++++++++++
 time/Makefile         |    8 ++++++
 wcsmbs/Makefile       |   13 ++++++++++
 wcsmbs/wcsmbs-tst1.c  |    2 +-
 12 files changed, 189 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18969] multiple string test failures due to missing locale dependencies

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18969

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.23

-- 
You are receiving this mail because:
You are on the CC list for the bug.