[Bug nss/18991] New: nss_files skips large entry in database

[Bug nss/18991] New: nss_files skips large entry in database

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18991

            Bug ID: 18991
           Summary: nss_files skips large entry in database
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nss
          Assignee: unassigned at sourceware dot org
          Reporter: schwab@linux-m68k.org
            Blocks: 18007
  Target Milestone: ---

If the nss_files getent method returns unsucessful due to the entry being too
large it doesn't reread the entry on the next call.  This is a regression
introduced by commit b13b96c ("Separate internal state between getXXent and
getXXbyYY NSS calls").


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=18007
[Bug 18007] nss state sharing causes application denial of service
(CVE-2014-8121)
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/18991] nss_files skips large entry in database

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18991

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
I wonder if it makes sense to switch to getline and heap allocation here.  This
would allow lookups to complete if the supplied buffer is sufficiently large
for the result, despite preceding lines too long to fit into the
caller-supplied buffer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/18991] nss_files skips large entry in database

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18991

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> ---
That requires keeping the line in an internal buffer between calls until the
caller's buffer is big enoough to return the entry.  Is that what you mean?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/18991] nss_files skips large entry in database

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18991

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Andreas Schwab from comment #2)
> That requires keeping the line in an internal buffer between calls until the
> caller's buffer is big enoough to return the entry.  Is that what you mean?

Yes, we'd have to keep the buffer around while the file is open.

-- 
You are receiving this mail because:
You are on the CC list for the bug.