[Bug build/19017] New: build failure in make subdirs=string tests=test-bcopy check

[Bug build/19017] New: build failure in make subdirs=string tests=test-bcopy check

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19017

            Bug ID: 19017
           Summary: build failure in make subdirs=string tests=test-bcopy
                    check
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: minor
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: msebor at redhat dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

Attempting to build and/or run a subset of tests fails in some directories. 
For example, invoking make as shown below to build and run just the test-bcopy
test fails with the subsequent error.  This is because the Makefile in those
directories contains the following lines:

tests-special += $(objpfx)tst-svc-cmp.out
$(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out

Adding the .out file to the tests-special variable then unconditionally
attempts the create it but because the file depends on tst-svc.out which cannot
be derived from the value of the tests variable the recipe fails.

$ nice make subdirs=string tests=test-bcopy check
...
make[2]: *** No rule to make target
`/build/glibc-trunk/power8/string/tst-svc.out', needed by
`/build/glibc-trunk/power8/string/tst-svc-cmp.out'.  Stop.
make[2]: Leaving directory `/src/glibc-trunk/string'
make[1]: *** [string/tests] Error 2
make[1]: Leaving directory `/src/glibc-trunk'
make: *** [check] Error 2
make: Leaving directory `/build/glibc-trunk/power8'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/19017] build failure in make subdirs=string tests=test-bcopy check

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19017

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
It's not obvious that "make tests=whatever" is expected to work, as 
opposed to the tests variable being strictly internal to the makefiles.  
My inclination would be to support "make subdir/some-test.out" to run a 
particular test (whether one from tests or tests-special), much like you 
can do "make subdir/tests" now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/19017] build failure in make subdirs=string tests=test-bcopy check

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19017

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.