[Bug math/19032] New: [i386] acosh (-qNaN) spurious "invalid" exception

[Bug math/19032] New: [i386] acosh (-qNaN) spurious "invalid" exception

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19032

            Bug ID: 19032
           Summary: [i386] acosh (-qNaN) spurious "invalid" exception
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
  Target Milestone: ---

The i386 versions of acoshf and acosh raise a spurious "invalid" exception for
an argument that is a quiet NaN with the sign bit set.

Failure: acosh (-qNaN): Exception "Invalid operation" set
Failure: acosh_downward (-qNaN): Exception "Invalid operation" set
Failure: acosh_towardzero (-qNaN): Exception "Invalid operation" set
Failure: acosh_upward (-qNaN): Exception "Invalid operation" set

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/19032] [i386] acosh (-qNaN) spurious "invalid" exception

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19032

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  93e448cbed1095c88133f2a304b1bbba72e480af (commit)
      from  f6d1d86d0c2cca118fd6a7734ea0ccd72b51c4b4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=93e448cbed1095c88133f2a304b1bbba72e480af

commit 93e448cbed1095c88133f2a304b1bbba72e480af
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Sep 30 18:06:02 2015 +0000

    Improve test coverage of real libm functions [a-e]*.

    This patch improves test coverage of the real libm functions [a-e]*,
    ensuring that special cases and ranges of input values of potential
    significance (such as close to overflow and underflow thresholds) are
    more systematically covered.

    This is a followup to
    <https://sourceware.org/ml/libc-alpha/2013-12/msg00757.html> which
    covered [a-c]* (however, I found more weaknesses in the coverage of
    those functions when preparing this patch, hence the additional tests
    being added for them here).

    Addition of a test for acosh (-qNaN) is temporarily deferred, to be
    included as part of a fix for bug 19032 which was discovered in the
    course of adding these tests (and which illustrates the use of testing
    -qNaN as well as +qNaN as input even to functions for which the sign
    of a NaN isn't meant to be significant).

    Tested for x86_64 and x86.

        * math/auto-libm-test-in: Add more tests of acos, acosh, asin,
        atan, atan2, atanh, cbrt, cos, cosh, erf, erfc, exp, exp10, exp2
        and expm1.
        * math/auto-libm-test-out: Regenerated.
        * math/libm-test.inc (acos_test_data): Add more tests.
        (asin_test_data): Likewise.
        (asinh_test_data): Likewise.
        (atan_test_data): Likewise.
        (atanh_test_data): Likewise.
        (atan2_test_data): Likewise.
        (cbrt_test_data): Likewise.
        (ceil_test_data): Likewise.
        (copysign_test_data): Likewise.
        (cos_test_data): Likewise.
        (cosh_test_data): Likewise.
        (erf_test_data): Likewise.
        (erfc_test_data): Likewise.
        (exp_test_data): Likewise.
        (exp10_test_data): Likewise.
        (exp2_test_data): Likewise.
        (expm1_test_data): Likewise.
        * sysdeps/x86_64/fpu/libm-test-ulps: Update.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |   25 +
 math/auto-libm-test-in            |  290 +
 math/auto-libm-test-out           |18454 +++++++++++++++++++++++++++++++++++++
 math/libm-test.inc                |  127 +-
 sysdeps/x86_64/fpu/libm-test-ulps |    4 +-
 5 files changed, 18891 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/19032] [i386] acosh (-qNaN) spurious "invalid" exception

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19032

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8c6c9236361fbc077769673c259828216403bc33 (commit)
      from  93e448cbed1095c88133f2a304b1bbba72e480af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8c6c9236361fbc077769673c259828216403bc33

commit 8c6c9236361fbc077769673c259828216403bc33
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Sep 30 21:44:42 2015 +0000

    Fix i386 acosh (-qNaN) spurious "invalid" exception.

    The i386 versions of acoshf and acosh raise a spurious "invalid"
    exception for an argument that is a quiet NaN with the sign bit set.
    The integer arithmetic to detect arguments < 1 also detects -NaN, and
    then the computation 0 / 0 in that case raises the exception.  This
    patch fixes this by using (x - x) / (x - x) as the computation in that
    case instead, which will always raise the exception for non-NaN
    arguments reaching that code, but not for quiet NaN arguments.

    Tested for x86_64 and x86.

        [BZ #19032]
        * sysdeps/i386/fpu/e_acosh.S (__ieee754_acosh): For arguments < 1,
        compute result as (x - x) / (x - x) not as 0 / 0.
        * sysdeps/i386/fpu/e_acoshf.S (__ieee754_acoshf): Likewise.
        * math/libm-test.inc (acosh_test_data): Add another test of acosh.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                   |    6 ++++++
 NEWS                        |    2 +-
 math/libm-test.inc          |    1 +
 sysdeps/i386/fpu/e_acosh.S  |    5 +++--
 sysdeps/i386/fpu/e_acoshf.S |    5 +++--
 5 files changed, 14 insertions(+), 5 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/19032] [i386] acosh (-qNaN) spurious "invalid" exception

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19032

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.23

--- Comment #3 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.