From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48726 invoked by alias); 7 Oct 2015 00:41:15 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 48660 invoked by uid 55); 7 Oct 2015 00:41:11 -0000 From: "cvs-commit at gcc dot gnu.org" To: glibc-bugs@sourceware.org Subject: [Bug math/19079] dbl-64/wordsize-64 lround based on llround incorrect for ILP32 Date: Wed, 07 Oct 2015 00:41:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: math X-Bugzilla-Version: 2.22 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-10/txt/msg00091.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=19079 --- Comment #1 from cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via b75bc69cdfe5247b2156ce249518f1c1df4d797d (commit) from a68dec3b03b9c163ad79192cbe837208b2f90de1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b75bc69cdfe5247b2156ce249518f1c1df4d797d commit b75bc69cdfe5247b2156ce249518f1c1df4d797d Author: Joseph Myers Date: Wed Oct 7 00:40:12 2015 +0000 Don't use dbl-64/wordsize-64 lround based on llround for ILP32 (bug 19079). The implementation of lround in dbl-64/wordsize-64 as an alias or wrapper for llround is always incorrect when long is not 64-bit, because it misses required exceptions in overflow cases, as shown by my recently added tests. This patch removes that alias / wrapper in the non-LP64 case, together with the REGISTER_CAST_INT32_TO_INT64 macro, restoring the previous version of lround for dbl-64/wordsize-64 (newly conditioned on !_LP64). Tested for x86_64, and for mips64 with use of dbl-64/wordsize-64 enabled. [BZ #19079] * sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c: Restore previous file, conditioned on [!_LP64]. * sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c [!_LP64] (__lround): Do not define as function or alias. [!_LP64] (lround): Likewise. [!_LP64] (__lroundl): Likewise. [!_LP64] (lroundl): Likewise. * sysdeps/tile/sysdep.h (REGISTER_CAST_INT32_TO_INT64): Remove macro. * sysdeps/x86_64/x32/sysdep.h (REGISTER_CAST_INT32_TO_INT64): Likewise. ----------------------------------------------------------------------- Summary of changes: ChangeLog | 15 +++++ NEWS | 2 +- sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c | 17 +----- sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c | 70 +++++++++++++++++++++++- sysdeps/tile/sysdep.h | 4 -- sysdeps/x86_64/x32/sysdep.h | 4 -- 6 files changed, 87 insertions(+), 25 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.