public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug math/19079] New: dbl-64/wordsize-64 lround based on llround incorrect for ILP32
@ 2015-10-06 23:36 jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` [Bug math/19079] " jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` cvs-commit at gcc dot gnu.org
0 siblings, 2 replies; 3+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2015-10-06 23:36 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=19079
Bug ID: 19079
Summary: dbl-64/wordsize-64 lround based on llround incorrect
for ILP32
Product: glibc
Version: 2.22
Status: NEW
Severity: normal
Priority: P2
Component: math
Assignee: unassigned at sourceware dot org
Reporter: jsm28 at gcc dot gnu.org
Target Milestone: ---
The implementation of lround in dbl-64/wordsize-64 as an alias or wrapper for
llround is always incorrect when long is not 64-bit, because it misses required
exceptions in overflow cases. E.g., for MIPS n32 modified to use this code:
Failure: lround (0x1p31): Exception "Invalid operation" not set
Failure: lround (0x1p32): Exception "Invalid operation" not set
Failure: lround (0x1p33): Exception "Invalid operation" not set
Failure: lround (-0x1p32): Exception "Invalid operation" not set
Failure: lround (-0x1p33): Exception "Invalid operation" not set
Failure: lround (-0x1p63): Exception "Invalid operation" not set
Failure: lround_downward (0x1p31): Exception "Invalid operation" not set
Failure: lround_downward (0x1p32): Exception "Invalid operation" not set
Failure: lround_downward (0x1p33): Exception "Invalid operation" not set
Failure: lround_downward (-0x1p32): Exception "Invalid operation" not set
Failure: lround_downward (-0x1p33): Exception "Invalid operation" not set
Failure: lround_downward (-0x1p63): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p31): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p32): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p33): Exception "Invalid operation" not set
Failure: lround_towardzero (-0x1p32): Exception "Invalid operation" not set
Failure: lround_towardzero (-0x1p33): Exception "Invalid operation" not set
Failure: lround_towardzero (-0x1p63): Exception "Invalid operation" not set
Failure: lround_upward (0x1p31): Exception "Invalid operation" not set
Failure: lround_upward (0x1p32): Exception "Invalid operation" not set
Failure: lround_upward (0x1p33): Exception "Invalid operation" not set
Failure: lround_upward (-0x1p32): Exception "Invalid operation" not set
Failure: lround_upward (-0x1p33): Exception "Invalid operation" not set
Failure: lround_upward (-0x1p63): Exception "Invalid operation" not set
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread* [Bug math/19079] dbl-64/wordsize-64 lround based on llround incorrect for ILP32
2015-10-06 23:36 [Bug math/19079] New: dbl-64/wordsize-64 lround based on llround incorrect for ILP32 jsm28 at gcc dot gnu.org
@ 2015-10-07 0:41 ` jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` cvs-commit at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2015-10-07 0:41 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=19079
Joseph Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |2.23
--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread* [Bug math/19079] dbl-64/wordsize-64 lround based on llround incorrect for ILP32
2015-10-06 23:36 [Bug math/19079] New: dbl-64/wordsize-64 lround based on llround incorrect for ILP32 jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` [Bug math/19079] " jsm28 at gcc dot gnu.org
@ 2015-10-07 0:41 ` cvs-commit at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-10-07 0:41 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=19079
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via b75bc69cdfe5247b2156ce249518f1c1df4d797d (commit)
from a68dec3b03b9c163ad79192cbe837208b2f90de1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b75bc69cdfe5247b2156ce249518f1c1df4d797d
commit b75bc69cdfe5247b2156ce249518f1c1df4d797d
Author: Joseph Myers <joseph@codesourcery.com>
Date: Wed Oct 7 00:40:12 2015 +0000
Don't use dbl-64/wordsize-64 lround based on llround for ILP32 (bug 19079).
The implementation of lround in dbl-64/wordsize-64 as an alias or
wrapper for llround is always incorrect when long is not 64-bit,
because it misses required exceptions in overflow cases, as shown by
my recently added tests. This patch removes that alias / wrapper in
the non-LP64 case, together with the REGISTER_CAST_INT32_TO_INT64
macro, restoring the previous version of lround for dbl-64/wordsize-64
(newly conditioned on !_LP64).
Tested for x86_64, and for mips64 with use of dbl-64/wordsize-64
enabled.
[BZ #19079]
* sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c: Restore previous
file, conditioned on [!_LP64].
* sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c
[!_LP64] (__lround): Do not define as function or alias.
[!_LP64] (lround): Likewise.
[!_LP64] (__lroundl): Likewise.
[!_LP64] (lroundl): Likewise.
* sysdeps/tile/sysdep.h (REGISTER_CAST_INT32_TO_INT64): Remove
macro.
* sysdeps/x86_64/x32/sysdep.h (REGISTER_CAST_INT32_TO_INT64):
Likewise.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 15 +++++
NEWS | 2 +-
sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c | 17 +-----
sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c | 70 +++++++++++++++++++++++-
sysdeps/tile/sysdep.h | 4 --
sysdeps/x86_64/x32/sysdep.h | 4 --
6 files changed, 87 insertions(+), 25 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-07 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 23:36 [Bug math/19079] New: dbl-64/wordsize-64 lround based on llround incorrect for ILP32 jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` [Bug math/19079] " jsm28 at gcc dot gnu.org
2015-10-07 0:41 ` cvs-commit at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).